Adapt the "onAlloyIteraction" and "canUpgrade" methods to subclasses of "ITier" #8252
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmyself8
changed the title
|
Please remove the generic, it's not needed. Just |
|
I changed them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
1.When adding extra alloys, the "AlloyTier" accepted by "onAlloyIteraction" is too limited. It would be better to replace it with a subclass of "ITier", at least I don't have to do repetitive work.
2.I modified the parameters in 'canUpgrade' to also adapt to subclasses of 'ITier', reducing unnecessary forced conversions.
3.Please forgive me for using a translator.
Thank you for everything you have done for mek.