Refactor name logic

meitner-se · May 6, 2024 · be15a89 · be15a89
1 parent e974bfe
commit be15a89
Showing 1 changed file with 17 additions and 6 deletions.
diff --git a/src/rules/noUsePrefixForNonHook.ts b/src/rules/noUsePrefixForNonHook.ts
@@ -83,16 +83,27 @@ function arrowFunctionHasImplicitReturnWithUsePrefix(
     );
 }
 
+function getArrowFunctionName(node: ArrowFunctionExpression) {
+    if (!("id" in node.parent)) {
+        return;
+    }
+
+    if (!node.parent.id) {
+        return;
+    }
+
+    if (!("name" in node.parent.id)) {
+        return;
+    }
+
+    return node.parent.id.name;
+}
+
 export const noUsePrefixForNonHook = ESLintUtils.RuleCreator.withoutDocs({
     create(context) {
         return {
             ArrowFunctionExpression(node) {
-                const name =
-                    "id" in node.parent &&
-                    node.parent.id &&
-                    "name" in node.parent.id
-                        ? node.parent.id?.name
-                        : "";
+                const name = getArrowFunctionName(node);
 
                 if (!name || !hasUsePrefix(name)) {
                     return;