-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
🚨 Breaking API change detected: Modified (3)
|
### Context | ||
|
||
This error occurs for the listed reasons: | ||
- if a value with a different type than `Array of Float` or `null` for `vector` is specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Array of Float
an existing type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An array of arrays and an empty array aren't supposed to work too?
Or is it not interesting to talk about here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a point in setting the value of the vector
field to null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macraig what do you mean by existing type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Kero
What is the default value of the vector
field at search-time? null
or []
?
If we don't accept []
, the default value specified should be null
for the field right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a point in setting the value of the vector field to null?
Depending on your code if you set a query and want to be sure not to use the vector.
[2023-07-13T16:05:55Z WARN meilisearch::search] Ignoring the query string `q` when used with the `vector` parameter.
### Context | ||
|
||
This error occurs for the listed reasons: | ||
- if a value with a different type than `Array of Float` or `null` for `vector` is specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An array of arrays and an empty array aren't supposed to work too?
Or is it not interesting to talk about here?
|
||
### Context | ||
|
||
These errors occurs when the `_vectors` field of a document payload is not valid. Either due to the type of it or the number of dimensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the type was already checked in the invalid_search_vector
. I'm not sure to understand when a synchronous or asynchronous error happens.
Co-authored-by: Maria Craig <[email protected]>
Co-authored-by: Maria Craig <[email protected]>
Co-authored-by: Maria Craig <[email protected]>
Co-authored-by: Maria Craig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
* Bump openapi.yaml file * Facet Search API (#246) * Init specification * Adjust spec files to PR number * Fix content-type open-api * Remove fix content-type * Add the telemetry * Update text/0246-facet-search-api.md Co-authored-by: cvermand <[email protected]> * Update text/0034-telemetry-policies.md --------- Co-authored-by: Clément Renault <[email protected]> Co-authored-by: cvermand <[email protected]> * Faceting Setting API - sortFacetValuesBy (#247) * init spec * Add property description and open-api.yaml * Removes future possibility * Update the telemetry * Update the error of the sortFacetValuesBy setting --------- Co-authored-by: Clément Renault <[email protected]> * Vector Search - `EXPERIMENTAL` (#248) * Init spec * Fix the vector store fields * Add an information on the invalid_search_vector error code * Add an information on the invalid_vectors_field error codes * Define the new max_vector_size analytic * Update the open-api file with vector capabilities * Apply suggestions from code review * Update open-api.yaml Co-authored-by: Maria Craig <[email protected]> * Update open-api.yaml Co-authored-by: Maria Craig <[email protected]> * Update text/0118-search-api.md Co-authored-by: Maria Craig <[email protected]> * Update text/0061-error-format-and-definitions.md Co-authored-by: Maria Craig <[email protected]> --------- Co-authored-by: Kerollmops <[email protected]> Co-authored-by: Maria Craig <[email protected]> * Tasks route total (#253) * Update the tasks route info to add the total field * Update the OpenApi of the tasks route * Document the latest metrics improvements (#242) * document the latest metrics improvements * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <[email protected]> * adds some details on the meilisearch_db_size metrics * update the open api metrics smaple * update a bad copy paste * Update open-api.yaml * prefix prometheus metrics by meilisearch_ * Introduce two new metrics --------- Co-authored-by: Guillaume Mourier <[email protected]> Co-authored-by: Kerollmops <[email protected]> --------- Co-authored-by: Guillaume Mourier <[email protected]> Co-authored-by: Clément Renault <[email protected]> Co-authored-by: cvermand <[email protected]> Co-authored-by: Clément Renault <[email protected]> Co-authored-by: Tamo <[email protected]>
🤖 API Diff
Summary
Describes the experimental vector search related properties and capabilities
Changes
vector
and_semanticScore
properties onsearch-api.md
_vectors
for a document bodyinvalid_search_vector
invalid_document_vectors_field
Out Of Scope
N/A
Attention To Reviewers
N/A
Misc
Telemetry
label)