Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Documents API — Support a csv delimiter customization #221

Merged
merged 4 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion text/0028-indexing-csv.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Also, in order to boost write performance CSV data format is more suited than JS

- The header of the csv payload allows to name the attributes and type them.
- `text/csv` Content-Type header is now supported.
- A new query parameter, `csvDelimiter`, has been introduced to customize the csv delimiter used in the document. It can change between two `documentAddition`.
- The error cases have been strengthened and completed. See Errors part.

### II. Motivation
Expand All @@ -43,11 +44,15 @@ While there's [RFC 4180](https://tools.ietf.org/html/rfc4180) as a try to add a

- The following CSV lines will represent a document for Meilisearch.
- A `,` character must separate each cell.
- A CSV value should be enclosed in double-quotes when it contains a comma character or a newline to escape it.
- A CSV value should be enclosed in double-quotes when it contains the delimiter character or a newline to escape it.
- Using double-quotes to enclose fields, then a double-quote appearing inside a field must be escaped by preceding it with another double quote as mentioned in [RFC 4180](https://tools.ietf.org/html/rfc4180).
- Float value should be written with a `.` character, like `3.14`.
- CSV text should be encoded in UTF8.
- The format can't handle array cell values. We are providing `nd-json` format to deal with theses types of attribute in a easier way.
- A `csvDelimiter` query parameter is available to customize the delimiter used in the documents.
- This `csvDelimiter` is optional. By default, the `,` character is used.
- The separator must be one [ascii char](https://www.rfc-editor.org/rfc/rfc20).
- The separator can't be used with another Content-Type, or else it'll throw an error.

##### `null` value

Expand Down Expand Up @@ -166,6 +171,7 @@ curl \
- 🔴 Sending a payload excessing the limit will lead to a 413 Payload Too Large - **payload_too_large** error code.
- 🔴 Sending an invalid CSV format will lead to a 400 bad_request - **malformed_payload** error code.
- 🔴 Sending a CSV header that does not conform to the specification will lead to a 400 bad_request - **malformed_payload** error code.
- 🔴 Sending an invalid csv delimiter: not exactly one ASCII char. This will lead to a 400 bad_request - **invalid_index_csv_delimiter** error code.
gmourier marked this conversation as resolved.
Show resolved Hide resolved

##### Errors Definition

Expand Down
22 changes: 22 additions & 0 deletions text/0061-error-format-and-definitions.md
Original file line number Diff line number Diff line change
Expand Up @@ -2765,6 +2765,28 @@ HTTP Code: `401 Forbidden`

---

## invalid_index_csv_delimiter
gmourier marked this conversation as resolved.
Show resolved Hide resolved

`Synchronous`

### Context

The csv delimiter must be exactly one char long, and this char must be an ASCII character.

### Error Definition

HTTP Code: `400 Bad Request`

```json
{
"message": "Invalid value in parameter `csvDelimiter`: expected a string of one character, but found the following string of 5 characters: `doggo`",
"code": "invalid_index_csv_delimiter",
gmourier marked this conversation as resolved.
Show resolved Hide resolved
"type": "invalid_request"
"link": "https://docs.meilisearch.com/errors#invalid_index_csv_delimiter",
gmourier marked this conversation as resolved.
Show resolved Hide resolved
}```

---

## 2. Technical details
n/a

Expand Down