-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
d7775d7
to
81a5dc1
Compare
81a5dc1
to
7e4c4b8
Compare
🤖 API change detected: Modified (2)
|
Is this considered breaking change? |
I don't think so because enabling page selection is opt-in and does not change the current behavior (< v0.30) if not used. |
Co-authored-by: Guillaume Mourier <[email protected]>
…/specifications into pagination-search-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some small changes that can be ignored.
More generally, I feel that there are too many explanations and examples for a specification.
However, these details could be interesting in the documentation.
Approved!
Co-authored-by: Many the fish <[email protected]>
@ManyTheFish I've updated the Since search events are aggregated, it's preferable to know which method was mostly used between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor changes
Co-authored-by: Guillaume Mourier <[email protected]>
Co-authored-by: Guillaume Mourier <[email protected]>
* Bump Meilisearch OpenAPI spec to v0.30.0 * Compression Headers (#178) * Start specification * Rename spec file * Rephrase summary * Rephrase receiving a compressed response section * Add links to RFC9910 * Introduce missing_master_key error (#179) * Update error message (#180) * Specify the error variant (#181) * replaces 127.0.0.1 by localhost (#184) * Configuration File Support (#185) * init spec file * Fill-in spec * Fix typing errors * adds errors case * Update text/0185-configuration-file.md Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Replace config file by configuration file in the error message * Update text/0185-configuration-file.md Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Update text/0185-configuration-file.md Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Update text/0185-configuration-file.md Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Update text/0185-configuration-file.md Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Add infos.with_configuration_file to telemetry-policies * Update text/0185-configuration-file.md Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Update text/0185-configuration-file.md Co-authored-by: Tamo <[email protected]> * Update text/0185-configuration-file.md Co-authored-by: Tamo <[email protected]> * Update text/0185-configuration-file.md Co-authored-by: Tamo <[email protected]> Co-authored-by: Clémentine Urquizar - curqui <[email protected]> Co-authored-by: Tamo <[email protected]> * Telemetry - Missing events and options (#186) * wip spec changes * update telemetry * add missing property to the full properties table * Update text/0034-telemetry-policies.md Co-authored-by: Tamo <[email protected]> * Update text/0034-telemetry-policies.md Co-authored-by: Tamo <[email protected]> * Add distrinct_attribute.set property, Task Seen becomes an aggregated event, add missing sub settings properties to Settings Updated event * Add requests.total_received property to Tasks Seen event * add missing ranking rules metrics * Update text/0034-telemetry-policies.md Co-authored-by: Tamo <[email protected]> * Update text/0034-telemetry-policies.md Co-authored-by: Tamo <[email protected]> * Update text/0034-telemetry-policies.md Co-authored-by: Tamo <[email protected]> * Precise max-index-size option (#187) * Tasks API - Rename `receivedDocumentsIds` by `providedIds` (#188) * Rename receivedDocumentsIds by matchedDocuments * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Clément Renault <[email protected]> * Add missing env vars, brings consistency (#190) * Swap Indexes API (#192) * Add new spec file as draft file * Add specification file * update spec * draft open-api.yml changes * Add errors * fix typos * Add Indexes Swapped event * duplicate_index_found is synchronous * Apply suggestions from code review Co-authored-by: Clémentine Urquizar - curqui <[email protected]> * Add review suggestions * Precis mention for tasks indexUid target swap in the history * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update text/0061-error-format-and-definitions.md Co-authored-by: Clément Renault <[email protected]> * Update text/0191-swap-indexes-api.md Co-authored-by: Clément Renault <[email protected]> Co-authored-by: Clémentine Urquizar - curqui <[email protected]> Co-authored-by: Clément Renault <[email protected]> * Add snapshotCreation as a new task type to make it visible in the task history (#193) * Tasks API - Add task priority order section (#194) * Add 2.1 Task Priority section * Precise other tasks priority ordering * Search API - Page Selection Component (#196) * Search API - numbered pagination * Improve numbered pagination explaination * Update text/0118-search-api.md * Update text/0118-search-api.md * Apply suggestions from code review * Add links * Update open api * Add a dot at the end of the title * Fix links * Improve page and hitsperpage query params * Refactor pagination guide * Fix wording * Add corner case * Update open-api.yaml Co-authored-by: Guillaume Mourier <[email protected]> * Update open-api.yaml Co-authored-by: Guillaume Mourier <[email protected]> * Update open-api.yaml Co-authored-by: Guillaume Mourier <[email protected]> * Apply wording changes from code review Co-authored-by: Guillaume Mourier <[email protected]> * Apply suggestions from code review Co-authored-by: Guillaume Mourier <[email protected]> Co-authored-by: Bruno Casali <[email protected]> * Fix example * Apply suggestions from code review Co-authored-by: Guillaume Mourier <[email protected]> * Update open-api.yaml * Update text/0118-search-api.md * Update links * Add link to maxtotalhits * Update text/0118-search-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Improve message in page reference * Update text/0118-search-api.md Co-authored-by: Many the fish <[email protected]> * Add telemetry to know the most used search results navigation methods in a batch * Update text/0118-search-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0118-search-api.md Co-authored-by: Guillaume Mourier <[email protected]> Co-authored-by: Guillaume Mourier <[email protected]> Co-authored-by: Bruno Casali <[email protected]> Co-authored-by: Many the fish <[email protected]> * Tasks API - Add task cancelation capability (#195) * Add cancel to task spec * Remove missing error * Fix typo on cancels * Fix IndexUid always null * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Add canceledBy and missing_filters error * Merge 11.1 filter iwth get and 11.2 filter with post * Specified every date filter * Change uid as integer and not as string * Add auto-batching and error * Add new route task/cancel api-key * Add global task note * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Guillaume Mourier <[email protected]> * Update text/0061-error-format-and-definitions.md Co-authored-by: Guillaume Mourier <[email protected]> * Modification due to review * Modification due to review * Modification due to review * Modification due to review * Fix global task link * Fix format link * Add open-api modification * Remove trailing space * Add clarification * Add errors definition * Update open-api.yml * fix task uid query parameter name * Fix collission between url path and query parameters * fmt open-api.yml * Add telemetry details * Add 202_taskCancelation example * Update originalQuery to originalFilters and update missing_task_filter to missing_task_filters * matchedTasks is computed when the task is enqueued * Apply suggestions from code review Co-authored-by: cvermand <[email protected]> * Apply suggestions from code review Co-authored-by: cvermand <[email protected]> * Recall explanation for filter query parameter and mentions that limit and from are valid on * Fix typo in property name * Update query paramters name and related error codes when invalid * Fix missing part of error msg * Precise valid date formats * Add supported format for date filters in open-api.yml * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update text/0060-tasks-api.md Co-authored-by: Clément Renault <[email protected]> * fix typo * Update open-api.yaml Co-authored-by: Clément Renault <[email protected]> * Update text/0060-tasks-api.md * Update text/0060-tasks-api.md * Tasks API - Add task deletion capability (#198) * Describes task deletion feature additions * Update open-api.yml * Update telemetry-policies * Update originalQuery to originalFilters * Follow title structure * Introduce review feedback * Branch the right components * Update text/0060-tasks-api.md Co-authored-by: Clément Renault <[email protected]> Co-authored-by: Clément Renault <[email protected]> Co-authored-by: Guillaume Mourier <[email protected]> Co-authored-by: cvermand <[email protected]> Co-authored-by: Clément Renault <[email protected]> * Update the dump support table with the dumpv6 (#199) * Settings API - Specify handling of null values when patching settings (#202) * Specify behavior when patching a setting with partial values and null values. - Partial value: the setting is unchanged. - null value: the setting is reset to default. * Settings: Update error messages to accept the null value * Add missing task types * Add canceledTasks details Co-authored-by: Clémentine Urquizar - curqui <[email protected]> Co-authored-by: Tamo <[email protected]> Co-authored-by: Clément Renault <[email protected]> Co-authored-by: cvermand <[email protected]> Co-authored-by: Bruno Casali <[email protected]> Co-authored-by: Many the fish <[email protected]> Co-authored-by: Amélie <[email protected]> Co-authored-by: Louis Dureuil <[email protected]>
217: Release v0.8.0 r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ##⚠️ Breaking changes This release is **only** compatible with the latest version of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) and greater * Rename meilisearch_host to meilisearch_url (#197) `@AdoPi` ## 🚀 Enhancements * Add the ability to define `pagination` settings in the model directly. (#208) `@yagince` * Use **finite pagination** strategy when `pagination_backend` is defined. (#214) `@brunoocasali` Read more about it [here](meilisearch/specifications#196) Thanks again to `@AdoPi,` `@brunoocasali,` `@curquiza,` and `@yagince!` 🎉 Co-authored-by: Bruno Casali <[email protected]>
🤖 API Diff
Summary
This specification introduces a new pagination system as an alternative to the
offset
/limit
. This pagination component can be used to navigate search results via a page selection.Changes
Previously, the only way to paginate over the search results was by using
limit
andoffset
which returned both these fields anestimatedTotalHits
.This feature introduces two new query parameters
page
andhitsPerPage
that lets you paginate over pages more easily. They add 4 new response fields:page
,hitsPerPage
,totalPages
andtotalHits
.When one system is used, only the fields of that pagination system are present in the response object.
When multiple fields from different pagination system are used, the
offset
/limit
system is used.Telemetry:
pagination.most_used_navigation
property forDocuments Searched POST
andDocuments Searched GET
eventsAttention To Reviewers
Corner cases may lack in precision.
Misc