Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure custom http client #359

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Allow to configure custom http client #359

merged 1 commit into from
Oct 17, 2024

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #357

What does this PR do?

  • Allows to configure custom http client

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the enhancement New feature or request label Oct 16, 2024
@norkunas norkunas mentioned this pull request Oct 16, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (19e198e) to head (2c3080e).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #359      +/-   ##
============================================
+ Coverage     88.62%   88.67%   +0.05%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           897      901       +4     
============================================
+ Hits            795      799       +4     
  Misses          102      102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curquiza
curquiza reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add a section in the README to document the usage?

@norkunas
Copy link
Collaborator Author

README doesn't have anything conf related, but we can add to the Wiki

curquiza
curquiza approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Oct 17, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit a4797cf into meilisearch:main Oct 17, 2024
14 checks passed
@norkunas
Copy link
Collaborator Author

@curquiza https://github.com/meilisearch/meilisearch-symfony/wiki/Http-Client not sure if I managed to properly explain

@norkunas norkunas deleted the custom-http-client branch October 17, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding custom headers to requests
2 participants
@norkunas @curquiza