Change the update status as enum and rename Type into UpdateType in Update model #71

ppamorim · 2020-10-10T14:28:49Z

This PR transforms the status result from the Update struct into an enum. This change is needed since the server has a stable API and the user doesn't want to keep comparing strings in the SDK.

ppamorim · 2020-10-10T14:37:05Z

bors try

bors · 2020-10-10T14:41:01Z

try

Build succeeded:

swift-test

Sources/MeiliSearch/Model/Update.swift

Tests/MeiliSearchIntegrationTests/UpdatesTests.swift

curquiza · 2020-10-12T14:39:05Z

Great test added! 👍

curquiza · 2020-10-12T15:49:35Z

bors try

bors · 2020-10-12T15:51:31Z

try

Build failed:

swift-test

ppamorim · 2020-10-12T17:37:42Z

I need to rebase this PR since the test is failing.

ppamorim · 2020-10-12T17:53:44Z

bors try

bors · 2020-10-12T17:59:04Z

try

Build succeeded:

swift-test

Tests/MeiliSearchIntegrationTests/UpdatesTests.swift

Sources/MeiliSearch/Model/Update.swift

Tests/MeiliSearchUnitTests/UpdatesTests.swift

Sources/MeiliSearch/Model/Update.swift

bors · 2020-10-14T13:42:15Z

Build failed:

swift-test

curquiza · 2020-10-14T13:49:54Z

bors try

bors · 2020-10-14T13:53:49Z

try

Build failed:

swift-test

curquiza · 2020-10-14T14:17:44Z

There is clearly a problem when installing MeiliSearch on the CI with brew... I don't have any issues on my local machine. And you guys @eskombro @ppamorim @bidoubiwa?

eskombro · 2020-10-14T14:58:32Z

There is clearly a problem when installing MeiliSearch on the CI with brew... I don't have any issues on my local machine. And you guys @eskombro @ppamorim @bidoubiwa?

I have no issues. Installing meilisearch with brew works fine for me!

We could install it on the CI with curl -L https://install.meilisearch.com | sh instead

brew update is loooooong :)

curquiza · 2020-10-14T15:00:54Z

Yes indeed we should change!
The script is done by humans, I would rather use docker as we do in the other SDKs, it works fine:
https://github.com/meilisearch/meilisearch-php/blob/ced74248be12f3ca594ce115419cf28d3ef6d609/.github/workflows/tests.yml#L35-L36

eskombro · 2020-10-14T15:01:50Z

+1 for docker

Sorry @ppamorim , I know this is not necessary related to your contribution :)

curquiza · 2020-10-14T15:14:28Z

Oh I remember, we spent a lot of time with Charlotte about that! Sorry again Pedro because it's not directly related to the issue.

We used to use the installation script, but we don't know why, it fails on macos-latest (only on CI. It works perfectly locally). See meilisearch/meilisearch#908
Docker is not installed on the macos-latest CI.
So, brew was the latest option...

Let's wait, it's maybe a GitHub issue... It worked a few hours ago.

eskombro · 2020-10-14T15:36:16Z

Let's wait, it's maybe a GitHub issue... It worked a few hours ago.

Ok! Indeed it probably is a connection/authentication issue coming from GitHub. So if it keeps doing the same we can create a new issue (for the swift CI specifically) and test/solve everything there!

ppamorim · 2020-10-14T17:18:43Z

@eskombro @curquiza Same error here: actions/runner-images#1811

ppamorim · 2020-10-14T17:27:22Z

Sorted with this change:

run: |
    brew uninstall [email protected]
    brew uninstall [email protected]
    brew untap local/openssl
    brew untap local/python2
    brew update

curquiza · 2020-10-14T17:30:00Z

If it's a temporary fix I would rather not add it.
If it's a definitive fix, I would rather have it in another PR please 🙂

curquiza · 2020-10-15T07:29:29Z

bors try

bors · 2020-10-15T07:32:40Z

try

Build succeeded:

swift-test

curquiza · 2020-10-15T07:34:19Z

bors merge

bors · 2020-10-15T07:37:10Z

Build succeeded:

swift-test

84: Fix CI r=curquiza a=ppamorim I don't see they fixing this issue, we are getting stuck due to this problem. Fixes crash in CI reported here: actions/runner-images#1811 Crash happening in the PR #71. Co-authored-by: Pedro Paulo de Amorim <[email protected]> Co-authored-by: Pedro Paulo Amorim <[email protected]>

ppamorim added enhancement New feature or request breaking-change The related changes are breaking for the users labels Oct 10, 2020

ppamorim requested a review from curquiza October 10, 2020 14:28

ppamorim self-assigned this Oct 10, 2020

ppamorim linked an issue Oct 10, 2020 that may be closed by this pull request

Replace Update.Result.status with enum values #55

Closed

bors bot added a commit that referenced this pull request Oct 10, 2020

Try #71:

1cad947

ppamorim added the Hacktoberfest label Oct 10, 2020

ppamorim requested a review from bidoubiwa October 12, 2020 12:38

curquiza reviewed Oct 12, 2020

View reviewed changes

bors bot added a commit that referenced this pull request Oct 12, 2020

Try #71:

ba601e0

curquiza changed the title ~~Result status as enum~~ Update status as enum Oct 12, 2020

ppamorim force-pushed the feature/updateResultStatus branch from 3ca04e0 to 995efc0 Compare October 12, 2020 17:39

Replace status:String with status:Result.Status enum

3d3ad75

ppamorim force-pushed the feature/updateResultStatus branch from 995efc0 to 3d3ad75 Compare October 12, 2020 17:44

bors bot added a commit that referenced this pull request Oct 12, 2020

Try #71:

fb06fbe

curquiza changed the title ~~Update status as enum~~ Change the update status as enum Oct 13, 2020

curquiza reviewed Oct 13, 2020

View reviewed changes

Tests/MeiliSearchIntegrationTests/UpdatesTests.swift Outdated Show resolved Hide resolved

bidoubiwa reviewed Oct 13, 2020

View reviewed changes

Sources/MeiliSearch/Model/Update.swift Outdated Show resolved Hide resolved

bidoubiwa suggested changes Oct 13, 2020

View reviewed changes

Tests/MeiliSearchUnitTests/UpdatesTests.swift Outdated Show resolved Hide resolved

Tests/MeiliSearchUnitTests/UpdatesTests.swift Outdated Show resolved Hide resolved

Sources/MeiliSearch/Model/Update.swift Outdated Show resolved Hide resolved

ppamorim requested review from curquiza and bidoubiwa October 14, 2020 00:00

ppamorim mentioned this pull request Oct 14, 2020

Addd waitForPending update method #73

Merged

bors bot added a commit that referenced this pull request Oct 14, 2020

Try #71:

31f6c61

curquiza mentioned this pull request Oct 14, 2020

Remove brew in the CI and use Docker instead to setup MeiliSearch #80

Closed

ppamorim dismissed stale reviews from curquiza and bidoubiwa via dbb5782 October 14, 2020 17:24

ppamorim mentioned this pull request Oct 14, 2020

Fix CI #81

Closed

Implement PR fixes

3715a7d

ppamorim force-pushed the feature/updateResultStatus branch from 35b61b1 to 3715a7d Compare October 14, 2020 17:39

curquiza changed the title ~~Change the update status as enum~~ Change the update status as enum and rename Type into UpdateType in Update model Oct 15, 2020

bors bot added a commit that referenced this pull request Oct 15, 2020

Try #71:

e294c39

curquiza approved these changes Oct 15, 2020

View reviewed changes

bors bot merged commit e21f2aa into master Oct 15, 2020

bors bot deleted the feature/updateResultStatus branch October 15, 2020 07:37

ppamorim mentioned this pull request Oct 23, 2020

Fix CI #84

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the update status as enum and rename Type into UpdateType in Update model #71

Change the update status as enum and rename Type into UpdateType in Update model #71

ppamorim commented Oct 10, 2020 •

edited

Loading

ppamorim commented Oct 10, 2020

bors bot commented Oct 10, 2020

curquiza commented Oct 12, 2020

curquiza commented Oct 12, 2020

bors bot commented Oct 12, 2020

ppamorim commented Oct 12, 2020

ppamorim commented Oct 12, 2020

bors bot commented Oct 12, 2020

bors bot commented Oct 14, 2020

curquiza commented Oct 14, 2020

bors bot commented Oct 14, 2020

curquiza commented Oct 14, 2020

eskombro commented Oct 14, 2020 •

edited

Loading

curquiza commented Oct 14, 2020

eskombro commented Oct 14, 2020 •

edited

Loading

curquiza commented Oct 14, 2020 •

edited

Loading

eskombro commented Oct 14, 2020 •

edited

Loading

ppamorim commented Oct 14, 2020

ppamorim commented Oct 14, 2020

curquiza commented Oct 14, 2020

curquiza commented Oct 15, 2020

bors bot commented Oct 15, 2020

curquiza commented Oct 15, 2020

bors bot commented Oct 15, 2020

Change the update status as enum and rename Type into UpdateType in Update model #71

Change the update status as enum and rename Type into UpdateType in Update model #71

Conversation

ppamorim commented Oct 10, 2020 • edited Loading

ppamorim commented Oct 10, 2020

bors bot commented Oct 10, 2020

try

curquiza commented Oct 12, 2020

curquiza commented Oct 12, 2020

bors bot commented Oct 12, 2020

try

ppamorim commented Oct 12, 2020

ppamorim commented Oct 12, 2020

bors bot commented Oct 12, 2020

try

bors bot commented Oct 14, 2020

curquiza commented Oct 14, 2020

bors bot commented Oct 14, 2020

try

curquiza commented Oct 14, 2020

eskombro commented Oct 14, 2020 • edited Loading

curquiza commented Oct 14, 2020

eskombro commented Oct 14, 2020 • edited Loading

curquiza commented Oct 14, 2020 • edited Loading

eskombro commented Oct 14, 2020 • edited Loading

ppamorim commented Oct 14, 2020

ppamorim commented Oct 14, 2020

curquiza commented Oct 14, 2020

curquiza commented Oct 15, 2020

bors bot commented Oct 15, 2020

try

curquiza commented Oct 15, 2020

bors bot commented Oct 15, 2020

ppamorim commented Oct 10, 2020 •

edited

Loading

eskombro commented Oct 14, 2020 •

edited

Loading

eskombro commented Oct 14, 2020 •

edited

Loading

curquiza commented Oct 14, 2020 •

edited

Loading

eskombro commented Oct 14, 2020 •

edited

Loading