Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Headers #431

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

Sherlouk
Copy link
Collaborator

@Sherlouk Sherlouk commented Nov 3, 2023

Pull Request

Related issue

Fixes #290

What does this PR do?

  • Adds a new parameter to initialiser to allow passing through of custom headers
  • Custom header will not override API key which takes highest precedence
  • Remove unused request parameter
  • Remove unused header parameters in network functions

Though the public signature does change (for removal of 'request'), it was never possible to initialise your own Request due to no public initialiser being provided. As such it's impossible for any client to have this parameter in use, and thus this is not a breaking change.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sherlouk
Copy link
Collaborator Author

Sherlouk commented Nov 6, 2023

bors merge

Copy link
Contributor

meili-bors bot commented Nov 6, 2023

@meili-bors meili-bors bot merged commit 914e606 into meilisearch:main Nov 6, 2023
6 checks passed
@curquiza curquiza added the enhancement New feature or request label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give the possibility to provide custom headers
3 participants