Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sync Indexes API #430

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Add Sync Indexes API #430

merged 7 commits into from
Dec 19, 2023

Conversation

Sherlouk
Copy link
Collaborator

@Sherlouk Sherlouk commented Nov 3, 2023

Pull Request

Related issue

Fixes #367

What does this PR do?

  • Introduces new swapIndexes API. This is NOT a breaking change.
  • Adds a new "wait" function to TaskInfo for cleaner async code (additive).

Worth noting that the above issue references an "API key action" and an error code. Neither of these are currently stored in the package and thus no changes needed.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sherlouk

LGTM 👌

bors merge

@curquiza curquiza added the enhancement New feature or request label Dec 19, 2023
Copy link
Contributor

meili-bors bot commented Dec 19, 2023

@meili-bors meili-bors bot merged commit ca7c180 into meilisearch:main Dec 19, 2023
6 checks passed
@Sherlouk Sherlouk deleted the sync-indexes branch December 19, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.30] Index name swapping with the new method POST /swap-indexes
2 participants