Added function for sending NDJSON documents #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: carlosb1 <[email protected]>
Signed-off-by: carlosb1 <[email protected]>
Signed-off-by: carlosb1 <[email protected]>
|
If it is good , i can start other stacked PRs
El mié., 16 ago. 2023 11:40, cvermand ***@***.***> escribió:
… Hey @carlosb1 <https://github.com/carlosb1>
Sorry for the delay! The code looks good to me :) I'm just checking
something with @irevoire <https://github.com/irevoire>, I should get back
to you very soon
—
Reply to this email directly, view it on GitHub
<#494 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAION56RR52VNZ2HNKUKAMDXVSIO7ANCNFSM6AAAAAA232LWXA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
bors merge |
|
Build succeeded: |
meili-bors bot
added a commit
that referenced
this pull request
Sep 12, 2023
519: Update version for v0.24.2 r=curquiza a=curquiza ## 🚀 Enhancements * Re-export public structures for better import path (#493) `@adriantombu` * Added function for sending NDJSON documents (#494) `@carlosb1` * Add missing startedAt field in EnqueuedTask (#485) `@sebastiantoh` * #499 (attributesToSearchOn) (#510) `@brendon-shf` * Add total field to get-tasks route (#509) `@hmacr` * Implement client for experimental-features API (#516) `@hmacr` Co-authored-by: curquiza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #191
What does this PR do?
Added the first two functions (with their tests) for issue #191. It includes two functions for sending njdson payloads
add_documents_ndjsonupdate_documents_ndjsonPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!