Merge #571

571: Make the error type implement Send + Sync + 'static r=curquiza a=irevoire

# Pull Request

## Related issue
Fixes #570

## What does this PR do?
- Make the error type implement Send + Sync + 'static
- Fix the awc example since their Error type doesn’t implement Send or Sync


Co-authored-by: Tamo <[email protected]>

examples/cli-app-with-awc/Cargo.toml

@@ -18,3 +18,4 @@ tokio = { version = "1.27.0", features = ["full"] }
 yaup = "0.2.0"
 tokio-util = { version = "0.7.10", features = ["full"] }
 actix-rt = "2.9.0"
+anyhow = "1.0.82"

examples/cli-app-with-awc/src/main.rs

@@ -59,23 +59,23 @@ impl HttpClient for AwcClient {
                 .content_type(content_type)
                 .send_stream(stream)
                 .await
-                .map_err(|err| Error::Other(Box::new(err)))?
+                .map_err(|err| Error::Other(anyhow::anyhow!(err.to_string()).into()))?
         } else {
             request
                 .send()
                 .await
-                .map_err(|err| Error::Other(Box::new(err)))?
+                .map_err(|err| Error::Other(anyhow::anyhow!(err.to_string()).into()))?
         };
 
         let status = response.status().as_u16();
         let mut body = String::from_utf8(
             response
                 .body()
                 .await
-                .map_err(|err| Error::Other(Box::new(err)))?
+                .map_err(|err| Error::Other(anyhow::anyhow!(err.to_string()).into()))?
                 .to_vec(),
         )
-        .map_err(|err| Error::Other(Box::new(err)))?;
+        .map_err(|err| Error::Other(anyhow::anyhow!(err.to_string()).into()))?;
 
         if body.is_empty() {
             body = "null".to_string();

src/errors.rs

@@ -62,7 +62,7 @@ pub enum Error {
     InvalidUuid4Version,
 
     #[error(transparent)]
-    Other(Box<dyn std::error::Error>),
+    Other(Box<dyn std::error::Error + Send + Sync + 'static>),
 }
 
 #[derive(Debug, Clone, Deserialize, Error)]