Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CONTRIBUTING.md #64

Merged
merged 7 commits into from
Jul 2, 2020
Merged

Create CONTRIBUTING.md #64

merged 7 commits into from
Jul 2, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jul 1, 2020 •
edited
Loading

@curquiza curquiza requested a review from eskombro July 1, 2020 16:58
eskombro
eskombro requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add a link in the README to the CONTRIBUTING?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
curquiza and others added 3 commits July 1, 2020 19:12
@curquiza @eskombro
Update CONTRIBUTING.md
3324756 
Co-authored-by: Samuel Jimenez <[email protected]>
@curquiza @eskombro
Update CONTRIBUTING.md
578944d 
Co-authored-by: Samuel Jimenez <[email protected]>
@curquiza @eskombro
Update CONTRIBUTING.md
e2cc0a9 
Co-authored-by: Samuel Jimenez <[email protected]>
@curquiza
Copy link
Member Author

curquiza commented Jul 1, 2020 •
edited
Loading

Shouldn't we add a link in the README to the CONTRIBUTING?

@eskombro Yes I think it's a good idea, can you suggest something (= what and where) in the right issue? 🙂

@curquiza
Copy link
Member Author

curquiza commented Jul 2, 2020

@eskombro I added your suggestion in the readme 🚀 !!

@curquiza curquiza requested a review from eskombro July 2, 2020 12:40
eskombro
eskombro approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@curquiza curquiza merged commit 6f24e8c into master Jul 2, 2020
@curquiza curquiza deleted the contributing branch July 2, 2020 15:13
bidoubiwa pushed a commit that referenced this pull request Mar 8, 2021
@curquiza @eskombro @bidoubiwa
Create CONTRIBUTING.md (#64)
5e56168 
* Create CONTRIBUTING.md

* Remove Dev Worflow from README

* Add minor changes on Contributing

* Update CONTRIBUTING.md

Co-authored-by: Samuel Jimenez <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Samuel Jimenez <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Samuel Jimenez <[email protected]>

* Add link to contributing file in README

Co-authored-by: Samuel Jimenez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskombro eskombro eskombro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @eskombro