Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for the next release (v0.19.0) #493

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Jul 11, 2022

This version makes this package compatible with Meilisearch v0.28.0 🎉
Check out the changelog of Meilisearch v0.28.0 for more information on the changes.

💥 Breaking changes

  • update_key() can update only name and description fields. Apply key changes #477
  • get_tasks() has additional parameters for filtering:: type, status and indexUid. Apply tasks changes #476
  • client.get_tasks(...) and index.get_tasks() now returns the following fields: results, limit, from, next.Apply tasks changes #476
  • index.search changes in the response fields: Apply indexes changes #478
    • nbHits replaced with estimatedTotalHits
    • exhaustiveNbHits is deleted
    • exhaustiveFacetsCount is deleted
    • matches renamed showMatchesPosition
    • facetsDistribution response parameter is renamed facetDistribution.
  • index.search changes in the request parameters: Apply indexes changes #478
    • matches renamed showMatchesPosition
    • facetsDistribution request parameter is renamed facets.
  • index.get_documents() request parameters: Apply documents changes #481
    • attributesToRetrieve replaced with fields.
  • client.get_indexes and client.get_raw_indexes now return the following fields: results, limit, offset, total. Apply indexes changes #478
  • index.get_documents and client.get_documents now return the following fields: results, limit, offset, total. Apply documents changes #481
  • index.get_documents query parameter attributesToRetrieve is now called fields Apply documents changes #481
  • client.get_dump_status and wait_for_dump_creation have been removed Apply dumps changes #479
  • client.create_dump() now returns tasks, similar to what add_documents or create_index returns Apply dumps changes #479
  • client.generate_tenant_token(api_key_uid, search_rules, expires_at) has now a mandatory api_key_uid parameter which should contain the uid of a specific API key. Add uid to the generateTenantToken method #484

🚀 Enhancements

@alallema alallema requested a review from bidoubiwa July 11, 2022 09:46
@bidoubiwa
Copy link
Contributor

bidoubiwa commented Jul 11, 2022

Changes required:

Breaking

index.get_tasks now use GET/tasks?indexUid=movies #476

We need to join the array values when filtering by status like this: [enqueued, processing]. #476

not sure these are a breaking change for the user. Not sure it is worth mentioning as well!

index.search changes in the response parameters: #478

In the response fields

_matchesInfo response parameter is renamed _matchesPosition

This is the wrong section with the request parameters

client.get_indexes and client.get_rawIndexes now returns the following fields: results, limit, offset, total

index.get_documents and client.getDocuments now returns the following fields: results, limit, offset, total

return not returns

client.get_dump_status and wait_for_dump_creation has been removed #479

Have been removed

client.create_dump() now returns an asynchronous task #479

Now returns tasks, similar to what add_documents or create_index returns.

Enhancements

index.get_tasks and client.get_tasks accept pagination metadata, added limit (default: 20), from.

index.get_tasks and client.get_tasks accept pagination parameters with limit (default: 20), from and next.

client.get_keys accept pagination metadata, added limit (default: 20), from.

client.get_keys accept pagination parameters, with limit (default: 20) and offset (default: 0).

client.get_indexes accept pagination metadata, added limit (default: 20), offset (default: 0), total. #478

client.get_indexes accept pagination parameters, with limit (default: 20) and offset (default: 0). #478

⚠️ Most points in enhancement are lacking a PR link

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibility to filter the results:

In the endpoint GET /tasks we can filter by: type, status and indexUid.

get_tasks() has additional parameters for filtering:

Also missing PR

client.getTasks(...) and index.getTasks() now returns the following fields: results, limit, from, next

get_tasks instead of getTasks

Also missing PR

index.search changes in the request parameters: #478

Since these are breaking changes maybe you can leave the details you left before:

  • matches renamed showMatchesPosition
  • facetsDistribution request parameter is renamed facets.
  • facetsDistribution response parameter is renamed facetDistribution.

index.get_documents query parameter attributesToRetrieve is now called fields #481

Same for get_document

client.create_dump() now returns an asynchronous task #479

Not very clear! As per my previous suggestion : Now returns tasks, similar to what add_documents or create_index returns

index.get_documents now accepts pagination parameters: limit, fields and offset. #481

now accepts pagination parameters: limit and offset.
Fields does not need to be included as it is not a pagination parameter and it has already been mentioned in breaking changes

client.get_indexes and client.get_rawIndexes now return the following fields: results, limit, offset, total
index.get_documents and client.getDocuments now return the following fields: results, limit, offset, total

These are missing a linked PR

@alallema alallema requested a review from bidoubiwa July 11, 2022 13:52
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 11, 2022

@bors bors bot merged commit 1d651a1 into main Jul 11, 2022
@bors bors bot deleted the update_version_to_v0.19.0 branch July 11, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants