-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version for the next release (v0.19.0) #493
Conversation
Changes required: Breaking
not sure these are a breaking change for the user. Not sure it is worth mentioning as well!
In the response
This is the wrong section with the request parameters
Now returns tasks, similar to what add_documents or create_index returns. Enhancements
index.get_tasks and client.get_tasks accept pagination parameters with
client.get_keys accept pagination parameters, with
client.get_indexes accept pagination parameters, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibility to filter the results:
In the endpoint GET /taskswe can filter by: type, status and indexUid.
get_tasks()
has additional parameters for filtering:
Also missing PR
client.getTasks(...) and index.getTasks() now returns the following fields: results, limit, from, next
get_tasks instead of getTasks
Also missing PR
index.search changes in the request parameters: #478
Since these are breaking changes maybe you can leave the details you left before:
matches
renamedshowMatchesPosition
facetsDistribution
request parameter is renamedfacets
.facetsDistribution
response parameter is renamedfacetDistribution
.
index.get_documents query parameter attributesToRetrieve is now called fields #481
Same for get_document
client.create_dump() now returns an asynchronous task #479
Not very clear! As per my previous suggestion : Now returns tasks, similar to what add_documents or create_index returns
index.get_documents now accepts pagination parameters: limit, fields and offset. #481
now accepts pagination parameters: limit and offset.
Fields does not need to be included as it is not a pagination parameter and it has already been mentioned in breaking changes
client.get_indexes and client.get_rawIndexes now return the following fields: results, limit, offset, total
index.get_documents and client.getDocuments now return the following fields: results, limit, offset, total
These are missing a linked PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
bors merge |
This version makes this package compatible with Meilisearch v0.28.0 🎉
Check out the changelog of Meilisearch v0.28.0 for more information on the changes.
💥 Breaking changes
update_key()
can update onlyname
anddescription
fields. Apply key changes #477get_tasks()
has additional parameters for filtering::type
,status
andindexUid
. Apply tasks changes #476client.get_tasks(...)
andindex.get_tasks()
now returns the following fields:results
,limit
,from
,next
.Apply tasks changes #476index.search
changes in the responsefields
: Apply indexes changes #478nbHits
replaced withestimatedTotalHits
exhaustiveNbHits
is deletedexhaustiveFacetsCount
is deletedmatches
renamedshowMatchesPosition
facetsDistribution
response parameter is renamedfacetDistribution
.index.search
changes in the request parameters: Apply indexes changes #478matches
renamedshowMatchesPosition
facetsDistribution
request parameter is renamedfacets
.index.get_documents()
request parameters: Apply documents changes #481attributesToRetrieve
replaced withfields
.client.get_indexes
andclient.get_raw_indexes
now return the following fields:results
,limit
,offset
,total
. Apply indexes changes #478index.get_documents
andclient.get_documents
now return the following fields:results
,limit
,offset
,total
. Apply documents changes #481index.get_documents
query parameterattributesToRetrieve
is now calledfields
Apply documents changes #481client.get_dump_status
andwait_for_dump_creation
have been removed Apply dumps changes #479client.create_dump()
now returns tasks, similar to what add_documents or create_index returns Apply dumps changes #479client.generate_tenant_token(api_key_uid, search_rules, expires_at)
has now a mandatoryapi_key_uid
parameter which should contain the uid of a specific API key. Add uid to the generateTenantToken method #484🚀 Enhancements
index.get_tasks
andclient.get_tasks
accept pagination metadata, addedlimit
(default: 20),from
. Apply tasks changes #476client.get_indexes
accept pagination metadata, addedlimit
(default: 20) andoffset
(default: 0). Apply indexes changes #478client.get_keys
accept pagination metadata, addedlimit
(default: 20) andoffset
(default: 0). Apply key changes #477client.get_key(key_or_uid)
can now also find keys based on their key uid. Apply key changes #477client.create_key(options)
lets you specify a custom uid (optionally) to create a new Key. Apply key changes #477index.get_documents
now accepts pagination parameters:limit
(default: 20) andoffset
(default: 0). Apply documents changes #481