-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds hybrid search options contract for multisearch #677
Conversation
@apozeus why you opened same code changes with two separate pull requests? 🙂 |
Oh my mistake. i thought i needed to open an issue then make a PR. |
Well you could open an issue and then link in the previous PR description 🙂 By the way, I've left some comments in your previous PR. |
Co-authored-by: Tomas Norkūnas <[email protected]>
Co-authored-by: Tomas Norkūnas <[email protected]>
Commited your comments. |
…ot be accessed before initialization
Ok so as you left this one open, then please apply all code change suggestions from previous PR |
it's all applied. |
Nope :) I don't see it, maybe you forgot to commit? |
Co-authored-by: Tomas Norkūnas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 83.91% 82.47% -1.45%
==========================================
Files 49 52 +3
Lines 1262 1318 +56
==========================================
+ Hits 1059 1087 +28
- Misses 203 231 +28 ☔ View full report in Codecov by Sentry. |
bors merge |
Pull Request
Related issue
Fixes #676
What does this PR do?
Adds hybrid search options contract for multisearch
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!