Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS #674

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix CS #674

merged 1 commit into from
Sep 15, 2024

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Sep 2, 2024

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.34%. Comparing base (ccd4cfd) to head (958e0a5).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   83.91%   83.34%   -0.57%     
==========================================
  Files          49       51       +2     
  Lines        1262     1303      +41     
==========================================
+ Hits         1059     1086      +27     
- Misses        203      217      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas norkunas mentioned this pull request Sep 9, 2024
3 tasks
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors bot merged commit 825d83e into meilisearch:main Sep 15, 2024
29 of 30 checks passed
@norkunas norkunas deleted the fix-cs branch September 16, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants