feat: Adds hybrid search options contract for multisearch #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Aug 29, 2024
Co-authored-by: Tomas Norkūnas <[email protected]>
Co-authored-by: Tomas Norkūnas <[email protected]>
norkunas
reviewed
Sep 10, 2024
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace MeiliSearch\Contracts; |
There was a problem hiding this comment.
Suggested change
| namespace MeiliSearch\Contracts; | |
| namespace Meilisearch\Contracts; |
norkunas
reviewed
Sep 10, 2024
| class HybridSearchOptions | ||
| { | ||
| private ?float $semanticRatio = null; | ||
| private ?string $embedder = null; |
There was a problem hiding this comment.
Suggested change
| private ?string $embedder = null; | |
| /** | |
| * @var non-empty-string|null | |
| */ | |
| private ?string $embedder = null; |
norkunas
reviewed
Sep 10, 2024
|
|
||
| return $this; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** | |
| * @return array{ | |
| * semanticRatio?: float, | |
| * embedder?: non-empty-string | |
| * } | |
| */ |
norkunas
reviewed
Sep 10, 2024
| @@ -27,6 +27,7 @@ class SearchQuery | |||
| private ?int $hitsPerPage; | |||
| private ?int $page; | |||
| private ?array $vector; | |||
| private ?HybridSearchOptions $hybrid; | |||
There was a problem hiding this comment.
Suggested change
| private ?HybridSearchOptions $hybrid; | |
| private ?HybridSearchOptions $hybrid = null; |
There was a problem hiding this comment.
I was testing it now too. and have made a similar commit. please check.
There was a problem hiding this comment.
You've commited it to another PR. so please choose one and close another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Adds hybrid search options contract for multisearch
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!