Update XML dist files #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Jan 10, 2024
| <env name="MEILISEARCH_URL" value="http://localhost:7700"/> | ||
| <env name="MEILISEARCH_API_KEY" value="masterKey"/> | ||
| </php> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" stopOnFailure="false" cacheResult="false" colors="true" cacheDirectory=".phpunit.cache"> |
There was a problem hiding this comment.
Maybe reference local schema that is shipped with phpunit,so you can open it in IDE?
There was a problem hiding this comment.
By the way, probably schemas are different on 9.5/10 so two of them should be shipped and selected which to run on which version, but you should check,maybe I'm wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a while since I don't touch the PHP repo, and I had to run
composer updatewhich raised a warning about having outdated XML files.I don't think this PR is warmful because I guess it is related to a new PHPUnit version.
And here we are!