Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct notation for getting documents #358

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Use the correct notation for getting documents #358

merged 1 commit into from
Jul 20, 2022

Conversation

brunoocasali
Copy link
Member

Fix an issue pointed initially here #353

@brunoocasali brunoocasali added the documentation Improvements or additions to documentation label Jul 19, 2022
@brunoocasali brunoocasali requested a review from alallema July 19, 2022 18:29
alallema
alallema reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to fully understand the changes here

tests/Search/SearchResultTest.php Outdated Show resolved Hide resolved
src/Contracts/IndexesResults.php Outdated Show resolved Hide resolved
@brunoocasali brunoocasali requested a review from alallema July 20, 2022 11:15
alallema
alallema approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@brunoocasali
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 20, 2022

Build succeeded:

@bors bors bot merged commit ef9e00d into main Jul 20, 2022
@bors bors bot deleted the fix-samples branch July 20, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas left review comments

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunoocasali @norkunas @alallema