Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents changes v2 #344

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Documents changes v2 #344

merged 5 commits into from
Jul 4, 2022

Conversation

brunoocasali
Copy link
Member

  • Create DocumentsQuery to handle pagination in documents endpoint.
  • Introduce DocumentsResults & make the getDocuments return a object
  • Add DocumentsQuery/Results to getDocuments handler

@brunoocasali brunoocasali requested a review from alallema July 1, 2022 18:53
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great 🎉

@brunoocasali brunoocasali merged commit 83f0f6a into bump-meilisearch-v0.28.0 Jul 4, 2022
@brunoocasali brunoocasali deleted the documents-v2 branch July 4, 2022 14:24
bors bot added a commit that referenced this pull request Jul 11, 2022
350: Update version for the next release (v0.24.0) r=brunoocasali a=brunoocasali

This version makes this package compatible with Meilisearch v0.28.0 🎉
Check out the changelog of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) for more information on the changes.

## 💥  Breaking changes

:warning: Small disclaimer: The `rawSearch` (and other `raw*` functions) are a direct connection between your PHP application and Meilisearch, you may find changes that are not present in this section.

- `MeiliSearch\Client->getDumpStatus` method was removed. (#336) `@brunoocasali`
- `MeiliSearch\Client->getIndexes` method now return a object type `IndexesResults`. (#341), (#345) `@brunoocasali`
- `MeiliSearch\Client->generateTenantToken` now require a `String apiKeyUid` which is the `uid` of the `Key` instance used to sign the token.  (#343) `@brunoocasali`
- `MeiliSearch\Client->createDump` now responds with `Task` object. (#336, #337) `@brunoocasali`
- `MeiliSearch\Client->getKeys` method now return a object type `KeysResults`. (#343), (#338) `@brunoocasali`
- `MeiliSearch\Client->updateKey` now can just update a `description` and/or `name`, if there are other key/value will be silently ignored. (#343), (#338) `@brunoocasali`
- `MeiliSearch\Client->getTasks` method now return a object type `TasksResults`. (#337), (#346) `@brunoocasali`
- `MeiliSearch\Index->getTasks` method now return a object type `TasksResults`. (#337), (#346) `@brunoocasali`
- `MeiliSearch\Index->search` `facetsDistribution` is now `facets` (#332) `@curquiza`
- `MeiliSearch\Index->search` `matches` is now `showMatchesPosition` (#332) `@curquiza`
- `MeiliSearch\Index->getDocuments` method now return a object type `DocumentsResults`.
- `MeiliSearch\Index->getDocuments` method now accepts a object as a parameter and `offset`, `limit`, `attributesToRetrieve` were not longer accepted.
- `exhaustiveNbHits`, `facetsDistribution`, `exhaustiveFacetsCount` were removed from `SearchResult`. (#332) `@curquiza`


## 🚀  Enhancements
- `MeiliSearch\Client->getIndexes` accepts a object `IndexesQuery` to filter and paginate the results.
- `MeiliSearch\Client->getKeys` accepts a object `KeysQuery` to filter and paginate the results. (#343), (#338) `@brunoocasali`
- `MeiliSearch\Client->getKey` accepts both a `Key#uid` or `Key#key` value. (#343), (#338) `@brunoocasali`
- `MeiliSearch\Client->getTasks` accepts a object `TasksQuery` to filter and paginate the results. (#337), (#346) `@brunoocasali`
- `MeiliSearch\Index->getTasks` accepts a object `TasksQuery` to filter and paginate the results. (#337), (#346) `@brunoocasali`
- `MeiliSearch\Client->createKey` can specify a `uid` (optionally) to create a new `Key`. (#343), (#338) `@brunoocasali`
- `MeiliSearch\Index->getDocument` accepts a `fields` list to compact the remap the response. (#340), (#344) `@brunoocasali`
- `MeiliSearch\Index->getDocuments` accepts a object `DocumentsQuery` to filter and paginate the results. (#340), (#344) `@brunoocasali`
- `Key` has now a `name` and `uid` string fields. (#343), (#338) `@brunoocasali`
- `estimatedTotalHits`, `facetDistribution` were added to `SearchResult` (#332) `@curquiza`
  - `nbHits` is still defined and will contain the same value as `estimatedTotalHits`.
- Sending a invalid `uid` or `apiKey` will raise `InvalidApiKeyException`. (#343) `@brunoocasali`

Thanks again to `@brunoocasali,` `@curquiza!` 🎉

Co-authored-by: Bruno Casali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants