Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize health method #157

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Standardize health method #157

merged 1 commit into from
Apr 15, 2021

Conversation

alallema
Copy link
Contributor

Checking that method health() return {'status': 'available'} and added isHealthy() method who return boolean value

meilisearch/integration-guides#55

@alallema alallema requested review from curquiza and bidoubiwa April 15, 2021 07:16
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion but apart from that LGTM 🔥

src/Delegates/HandlesSystem.php Outdated Show resolved Hide resolved
@alallema alallema force-pushed the fix-standardize_health_method branch from cea5a50 to 201bf87 Compare April 15, 2021 10:41
@alallema alallema requested a review from bidoubiwa April 15, 2021 10:46
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 15, 2021

@bors bors bot merged commit 1376a96 into main Apr 15, 2021
@bors bors bot deleted the fix-standardize_health_method branch April 15, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants