Update delete index to always return an array #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emulienfou are you ok with that? 🙂 |
|
@curquiza Indeed, perfect for me |
ppshobi
approved these changes
Oct 1, 2020
curquiza
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Thanks @pedroxido for your work!
And thanks @ppshobi and @emulienfou for your incredible reactivity, as usual 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
As per the discussion in the related issue, the method
HandlesIndex::deleteIndexreturns void but should return an array given that Meilisearch delete api could return an array in the future.Added few lines to always return the array from the Meilisearch delete response, if null, returns an empty array