fix MeiliSearch\Search\SearchResult as array

[olivM]

fix "Cannot use object of type MeiliSearch\Search\SearchResult as array"

[olivM]

when i do a custom search with or without options, i got this error

PHP Error:  Cannot use object of type MeiliSearch\Search\SearchResult as array in /Users/olivm/Workspace/Rigpa/vendor/meilisearch/meilisearch-laravel-scout/src/Engines/MeilisearchEngine.php on line 176�

( doing a simple MyModel::search() does work fine )

[francoism90]

@olivM I tried your PR, but I don't think it works correctly:

[2021-01-30 09:27:47] staging.ERROR: Call to a member function getHitsCount() on array {"userId":1,"exception":"[object] (Error(code: 0): Call to a member function getHitsCount() on array at /srv/http/project/api/vendor/meilisearch/meilisearch-laravel-scout/src/Engines/MeilisearchEngine.php:175)

Book::search('prince', function (Indexes $meilisearch, $query, $options) {
            // $options['filters'] = 'author="Antoine de Saint-Exupéry"';

            return $meilisearch->search($query, $options);
        })->take(3)->get();

[mmachatschek]

I would suggest to check if the $results parameter is a SearchResult object before and then casting the object to an array.

e.g.

if ($results instanceof SearchResult) {
    $results = $results->toArray();
}

[shokme]

Correct me if I'm wrong, but if in the custom search we use rawSearch() instead of search() we can keep count($results['hits']) instead of ->getHitsCount() ?

[mmachatschek]

@shokme correct. but I think as you mentioned in #87 (comment) that the PHP SDK (I didn't check on this) changed, it may be that other integrations are broken or will break if updated to the newer versions.

With my change we could also fix older integrations that copied the example from the docs with ->search() in their custom query.

[mmachatschek]

@shokme the only change needed to work with the new behaviour would be my suggestion from #86 (comment)

[shokme]

I don't remember everything about the PHP SDK changes, but it safe as long as it allow us to work with arrays and as I remember it will.

if we do this change, we should do it for every case (I didn't check if there is more than just that one) that can throw the object as array error.
We should find a away to have the ->toArray() conversion earlier than in each methods ?

Anyway, it is hard to me to find time at the moment. So I can't work on making everything perfect right now.
If you have free time and want to do it feel free to open another PR that will apply your change on every case that could throw an object as array error.(if this is the only one let me now and I will merge it of course)

Thank you for your time !

[shokme]

As mentioned here #86 (comment)
I have to check everything and may change more methods.

I let decide @curquiza if we close this PR in favour of a new one that allow this package to work with the SearchResult object.

Thank you for your time everyone.

[curquiza]

Hello everyone! 🙂
Yes I would rather a PR that allows the package to work with the SearchResult object.
I'm closing this one, but thanks @olivM for your suggestion, this is always nice to work with the community. Sorry your PR will not be merged, I hope the next one will be a good one (in this repo or in another one 😁)
Thanks everyone for your involvement here!

(feel free to re-open it @shokme if I missed something)