Update meilisearch-php to v0.14

[bensherred]

Updated the meilisearch-php dependency to v0.14.0. This fixes any locked dependency issues with guzzle 6 to allow any psr18 compatible HTTP client to be used instead.

This will fix #43.

As Laravel comes with Guzzle out the box, we do not need to require the additional installation of the following dependencies php-http/guzzle6-adapter:^2.0

[shokme]

Hello @bensherred

You still need: http-interop/http-factory-guzzle else the http/discovery will not be able to found the factory.
No PSR-17 request factory found

[bensherred]

Ah that makes sense, I've gone ahead and added that. Thanks for your help @shokme.

[shokme]

There is a problem, you need to instantiate Guzzle inside the MeilisearchServiceProvider that break all laravel version that are not using Guzzle 7.

But I found a potential solution I have to discuss with ppshobi about it. see you in meilisearch/meilisearch-php#76

need clarification before approval

[curquiza]

Has laravel framework its own HTTP client that we can provide?
Shouldn't we add guzzle 6 as a dependency in this package?

[bensherred]

@curquiza Laravel has a HTTP Client but it's just a wrapper for Guzzle. We can't require guzzle 6 either as Laravel 8 now uses Guzzle 7 instead.

[bensherred]

Following the updates to meilisearch/meilisearch-php, did we want to try using the alpha here as well? Currently we can't use the scout driver with Laravel 8 so might be helpful to try that.

[curquiza]

Hum, not really good to have an alpha version in our codebase. Plus if everything is good during testing, I will create the official v0.14.1 this afternoon after my lunch (Paris local time 😅). All should be fixed at the end of this day (Paris local time again sorry) maximum.

[bensherred]

Ah, that makes sense, I wasn't sure what your plans were on an official release. No point updating supporting alpha if it will likely be released this afternoon.

[curquiza]

Some questions and remarks! 🙂

[curquiza]

Aren't http-interop/http-factory-guzzle installed by default in Laravel 8 as Guzzle 7 is? 🤞

[bensherred]

I don't think Laravel comes with http-interop/http-factory-guzzle installed, here's the composer.json. I've had a look through those dependencies as well and doesn't look like any require them.

[bensherred]

It might be worth removing still though as it's only required for Guzzle 6 and 7. I could add a note in the README about it?

[shokme]

No the factory is not installed by default.
This is only here to exploit PSR-17 (the php sdk discover the factory and use it for thing like $this->requestFactory->createRequest(...).

I don't know if we should remove it, a part of me is yeah we should because we don't want to "tie" the package with guzzle but in other hand as laravel pre-install guzzle since the version 7 why should we not simplify user life by pre-installing the factory, it will be good for most of laravel users.

For me both are ok, but I prefer option 2 😛

[curquiza]

Let's keeping it (option 2). If someone is struggling with this decision, we will see!

[curquiza]

Could we add a line for Guzzle 7:

$ composer require guzzlehttp/guzzle

For users using Laravel < 8 but who want to use guzzle 7

[shokme]

Is it ok to you ?

[curquiza]

Thanks again for this PR @bensherred!
Could you rebase your branch, please? 🙂

[bensherred]

Not sure if I am doing something wrong with the rebase @curquiza?

[curquiza]

@bensherred, it looks like you did not do the first step Add the main repository as a remote of the gist, see the error: 'upstream' does not appear to be a git repository.

I don't know if you join to our Slack, but if you want direct chatting for the rebase, join us (I'm Clementine).

[curquiza]

If you think all is ready @shokme, you can merge when you want! 🙂