Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for specifying Nodeport in service #87

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Support for specifying Nodeport in service #87

merged 2 commits into from
Nov 17, 2021

Conversation

Thearas
Copy link
Contributor

@Thearas Thearas commented Nov 13, 2021

Pull Request

What does this PR do?

Implement #50.

alallema
alallema reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Thearas for this PR!
You need to update the version in charts/meilisearch/Chart.yaml every time you modify a file inside the charts directory.

@Thearas
Copy link
Contributor Author

Thearas commented Nov 17, 2021

Done.

PTAL again @alallema.

alallema
alallema approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for contributing to Meilisearch @Thearas

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 17, 2021

Build succeeded:

@bors bors bot merged commit 23f5755 into meilisearch:main Nov 17, 2021
@Thearas Thearas deleted the svc-nodeport branch November 17, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thearas @alallema