Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SearchCutoffMs #1645

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Apr 19, 2024

Pull Request

Related issue

Fixes #1639

What does this PR do?

  • Update type and methods for the searchCutoffMs API
  • Update tests for the searchCutoffMs API in settings.test.ts and searchCutoffMs.test.ts
  • Update the test snapshots
  • Update the README

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for finishing the work here 🤩
You've done an amazing work 👏 🥳 ❤️ 🌻

@mdubus mdubus merged commit 0dc6d90 into meilisearch:bump-meilisearch-v1.8.0 Apr 22, 2024
6 of 10 checks passed
@brunoocasali brunoocasali added the enhancement New feature or request label May 6, 2024
meili-bors bot added a commit that referenced this pull request May 6, 2024
1648: Update version for the next release (v0.39.0) r=brunoocasali a=meili-bot

## 🚀 Enhancements

* feat: hybrid search improvements for v1.8.x (#1647) `@mdubus`
* Add `null` to Embedder type (#1646) `@amit-ksh`
* Add searchCutoffMs index setting (#1643, #1645) `@amit-ksh`
    ```js
    client.index('movies').getSearchCutoffMs()
    client.index('movies').updateSearchCutoffMs(150)
    client.index('movies').resetSearchCutoffMs()
    ```

## ⚙️ Maintenance/misc

* Update ESLint, Prettier, TypeScript and fix/improve their configuration files (#1616) `@flevi29`
* Fix code style after configuration changes (#1638) `@brunoocasali`

Thanks again to `@amit-ksh,` `@brunoocasali,` `@curquiza,` `@flevi29,` `@mdubus,` `@meili-bors[bot]` ! 🎉


Co-authored-by: meili-bot <[email protected]>
@amit-ksh amit-ksh deleted the feat/update-searchCutoffMs branch June 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants