Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys parameter in missing routes v0.28.x #1283

Merged

Conversation

bidoubiwa
Copy link
Contributor

  • deleteKey and updateKey are also able to be recognizable by either the uid or the key.

@brunoocasali
Copy link
Member

@bidoubiwa bidoubiwa marked this pull request as ready for review June 30, 2022 08:39
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@bidoubiwa
Copy link
Contributor Author

bors merge

@bidoubiwa bidoubiwa merged commit ed23994 into bump-meilisearch-v0.28.0 Jul 4, 2022
@bidoubiwa bidoubiwa deleted the add_keys_parameter_in_missing_routes branch July 4, 2022 10:27
meili-bors bot added a commit that referenced this pull request Jul 4, 2022
1283: Add keys parameter in missing routes v0.28.x r=bidoubiwa a=bidoubiwa

- `deleteKey` and `updateKey` are also able to be recognizable by either the `uid` or the `key`.

Co-authored-by: Charlotte Vermandel <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 4, 2022

Build failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants