Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http methods in settings routes v0.28 #1262

Merged
merged 16 commits into from
Jun 20, 2022

Conversation

bidoubiwa
Copy link
Contributor

Changes related to the HTTP verbs

Related to:
issue: meilisearch/meilisearch#2419

  • PATCH /indexes/{indexUid}/settings instead of POST
  • PATCH /indexes/{indexUid}/settings/typo-tolerance instead of POST
  • PUT /indexes/{indexUid}/settings/displayed-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/distinct-attribute instead of POST
  • PUT /indexes/{indexUid}/settings/filterable-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/ranking-rules instead of POST
  • PUT /indexes/{indexUid}/settings/searchable-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/sortable-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/stop-words instead of POST
  • PUT /indexes/{indexUid}/settings/synonyms instead of POST

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 15, 2022
@bidoubiwa bidoubiwa changed the base branch from main to update_get_indexes_routes June 15, 2022 15:23
@bidoubiwa bidoubiwa requested review from brunoocasali and mdubus June 15, 2022 15:27
@bidoubiwa bidoubiwa force-pushed the update_http_methods branch from 9bb0b65 to 14318bb Compare June 15, 2022 15:32
@bidoubiwa bidoubiwa force-pushed the update_http_methods branch from 14318bb to 6de4a54 Compare June 15, 2022 15:34
src/indexes.ts Outdated Show resolved Hide resolved
src/indexes.ts Outdated Show resolved Hide resolved
@bidoubiwa bidoubiwa requested a review from brunoocasali June 16, 2022 10:21
@bidoubiwa bidoubiwa changed the title Update http methods in settings routes Update http methods in settings routes v0.28 Jun 16, 2022
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Base automatically changed from update_get_indexes_routes to bump-meilisearch-v0.28.0 June 20, 2022 10:42
@bidoubiwa bidoubiwa merged commit 6fcd2a3 into bump-meilisearch-v0.28.0 Jun 20, 2022
@bidoubiwa bidoubiwa deleted the update_http_methods branch June 20, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants