Skip to content

Commit

Permalink
Merge #1698
Browse files Browse the repository at this point in the history
1698: Add `"packageManager"` entry to package.json r=brunoocasali a=flevi29

# Pull Request

## Why?
- [`corepack`](https://nodejs.org/docs/latest-v20.x/api/corepack.html) [started adding this field automatically](nodejs/corepack#413), which can be disabled, but everyone has to do it separately, which is very annoying
- anyhow there's no harm in it, `corepack` recommends it even in the "how to disable" doc https://github.com/nodejs/corepack/blob/main/README.md#environment-variables
  - > it ensures that your project installs are always deterministic (if you use `corepack`)
- this does mean that this field will have to be updated periodically, but this is the recommended way

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: F. Levi <[email protected]>
  • Loading branch information
meili-bors[bot] and flevi29 authored Sep 15, 2024
2 parents f66d0ae + a7d2cdf commit aafa15c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,5 +108,6 @@
"ts-jest": "^29.1.1",
"typedoc": "^0.25.13",
"typescript": "^5.3.3"
}
},
"packageManager": "[email protected]"
}

0 comments on commit aafa15c

Please sign in to comment.