Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for distinct attribute #1313

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

thomas-lcdp
Copy link
Contributor

Pull Request

Related issue

Fixes #1312

What does this PR do?

  • Add support for distinct attribute

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: f2bb298

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@meilisearch/instant-meilisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@curquiza curquiza added the enhancement New feature or request label Aug 7, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thomas-lcdp

Thanks for the PR

Can you do a separated PR for the changes NOT related to distinct, like the changes you made about indentation (especially because I don't agree with all, and I don't want to block a PR for this)

Also, can you fix the style CI? 😊

@thomas-lcdp
Copy link
Contributor Author

Hello @curquiza

I fix the indentation which has fix the CI :)

@curquiza
Copy link
Member

curquiza commented Aug 7, 2024

Thank you very much @thomas-lcdp!! 😄

Finally can you run yarn changeset? More information in our CONTRIBUTING steps

I will merge right after

@thomas-lcdp
Copy link
Contributor Author

I do the changeset. I hope it is correct.
Thanks

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectoooo

thank you

bors merge

@meili-bors meili-bors bot merged commit c36580e into meilisearch:main Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to distinct
2 participants