-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for distinct attribute #1313
Add support for distinct attribute #1313
Conversation
🦋 Changeset detectedLatest commit: f2bb298 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @thomas-lcdp
Thanks for the PR
Can you do a separated PR for the changes NOT related to distinct, like the changes you made about indentation (especially because I don't agree with all, and I don't want to block a PR for this)
Also, can you fix the style CI? 😊
Hello @curquiza I fix the indentation which has fix the CI :) |
Thank you very much @thomas-lcdp!! 😄 Finally can you run I will merge right after |
I do the changeset. I hope it is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfectoooo
thank you
bors merge
Pull Request
Related issue
Fixes #1312
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!