Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add facet search support #735

Merged
merged 2 commits into from
May 23, 2024
Merged

Add facet search support #735

merged 2 commits into from
May 23, 2024

Conversation

the-sinner
Copy link
Contributor

Pull Request

Related issue

Fixes #635

What does this PR do?

  • implement facet search

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@the-sinner the-sinner marked this pull request as ready for review May 21, 2024 16:23
curquiza
curquiza approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @the-sinner for all these PRs

bors merge

@curquiza curquiza added the enhancement New feature or request label May 23, 2024
@curquiza curquiza changed the title implement facet search Add facet search support May 23, 2024
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 23, 2024

Build succeeded:

  • integration-and-unit-tests
  • linter

@meili-bors meili-bors bot merged commit 49919bd into meilisearch:main May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.3] Search in facet values facetSearch
2 participants
@the-sinner @curquiza