Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SearchRequest.java file according to the recomendations po… #575

Closed
wants to merge 2 commits into from

Conversation

ancatoza
Copy link

Pull Request

Related issue

Fixes #573

What does this PR do?

This PR makes an updated on the SearchRequest. java file where another contributor tracked for a period of time and found the SearchRequest.toString() problem:
When String [] is used as key and value, it will not be serialized, so according with the recommendations this code would solve the problem before serializing to httpRequest.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @ancatoza,
Thank you for this PR! I advise you to read the CONTRIBUTING file, try to build the project and also to pass the linter with this command line:

./gradlew spotlessApply

The code seems great but you will need to add a test for this new method getStrArrays in src/test/java/com/meilisearch/sdk/SearchRequestTest.java and also one to check if the bug from the issue it still present

@alallema alallema added the bug Something isn't working label Mar 27, 2023
@brunoocasali
Copy link
Member

Hi @alallema and @ancatoza as stated here #573 (comment)

There is no real evidence of this issue, and in fact, we do have test coverage for that specific use case. So, until we don't have a reproducible use case in our tests or outside of it, like the repo I suggested in the linked comment, I don't see the point of keeping this PR open!

I appreciate the effort @ancatoza feel free to keep contributing!

CC: @alallema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I found a bug in serializing with SearchRequest.toString()
3 participants