Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matching strategy enum usage and add test #561

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

alallema
Copy link
Contributor

This PR corrects the use of the matchingStrategy enum which sends all and last in upper case instead of lower case.

@alallema alallema added the bug Something isn't working label Feb 27, 2023
@alallema alallema linked an issue Feb 27, 2023 that may be closed by this pull request
@alallema
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

Build succeeded:

  • integration-and-unit-tests
  • linter

@bors bors bot merged commit 8a971cc into main Feb 27, 2023
@bors bors bot deleted the patch-matching-strategy branch February 27, 2023 16:21
bors bot added a commit that referenced this pull request Feb 27, 2023
553: Update version for the next release (v0.11.0) r=alallema a=meili-bot

This version makes this package compatible with Meilisearch v0.30.0 🎉
Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes(#382).

## ⚠️ Breaking changes

* Add a builder for `SearchRequest` class (#543) `@alallema`
   - The search method can now only be instantiated:
   ```java
      SearchResult search(String q)
      Searchable search(SearchRequest searchRequest)
   ```
* Parameters on `getTasks` name changes: #390
   - `status` -> `statuses`
   - `indexUID` -> `indexUIDS`
   - `type` -> `types`
* New `pagination` strategy with the search parameters `page` and `hitsPerPage` #546
   - `public Searchable search(SearchRequest searchRequest)` method now return `Searchable` which can be extended to two different classes of results `SearchResult` and `SearchResultPaginated`
   - `SearchResult` is now an extended class of `Searchable`
   - Creation of the `SearchResultPaginated` class to handle pagination results from search
   - Creation of a common search result class `Searchable`

## 🚀 Enhancements

* Implement `getRawIndexes` with query parameters (#558) `@oraliahdz`
* New filters on `setTasks`: `uid`, `beforeEnqueuedAt`, `afterEnqueuedAt`, ... see #544
* New `client.cancelTasks` method that lets you cancel `enqueued` and `processing` tasks #547
* New `client.deleteTasks` method that lets you delete tasks #548
* New `client.swapIndexes` method that lets you swap two indexes #554 
* New fields on `TaskDetails` and modification of ``TaskInfo` #545

## 🐛 Bug Fixes

* Fix: #550 Add a constructor to initialize HttpClient using Gson by default (#551) `@gpor0`
* Fix matching strategy enum usage and add test (#561) `@alallema`

Thanks again to `@alallema,` `@gpor0` and `@oraliahdz!` 🎉



Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Amélie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using MatchingStrategy enum
2 participants