Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure the CSV delimiter when updating documents #590

Open
2 tasks
brunoocasali opened this issue Apr 27, 2023 · 0 comments
Open
2 tasks

Configure the CSV delimiter when updating documents #590

brunoocasali opened this issue Apr 27, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, feel free to add any clarification and instruction about this issue.

Sorry if this is already partially/completely implemented, feel free to let me know about the state of this issue in the repo.

Related to meilisearch/integration-guides#251

Related to:

Add support for passing csvDelimiter query parameter to the PUT and POST /indexes/:indexUid/documents with content-type text/csv (example of the real method names: updateDocuments, addDocuments).

Also, a new error code is introduced, invalid_document_csv_delimiter. Pay attention to the strongly typed languages.

TODO:

  • Add the new argument to the csv document handler methods.
  • Add tests
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Apr 27, 2023
@jennweir jennweir mentioned this issue Apr 22, 2024
Merged
5 tasks
meili-bors bot added a commit that referenced this issue May 15, 2024
@meili-bors @amei34 @jennweir
Merge #726
e6a7c16 
726: Custom csv delimiter r=curquiza a=jennweir

# Pull Request

## Related issue
Addresses #590 

## What does this PR do?
- Includes csvDelimiter parameter in the addDocuments method
- Includes csvDelimiter parameter in the updateDocuments method
### Issue #590 has two subtasks as listed below:
- [x] Add the new argument to the csv document handler methods
- [ ] Add tests
- Tests are not included because there are some clarifications that we require to verify if the issue is already partially/completely implemented. After adding the csvDelimiter to each method, we researched adding a custom csv delimiter in Java and found no built-in support. Would this be best completed by utilizing an external library like OpenCSV? 
- This PR addresses the function parameter additions to support a custom csvDelimiter if necessary but does not adequately test the functionality of these additions. 
- It is unclear from the issue if this is already implemented, this would address the first subtask for #590 if the issue has not been implemented yet.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Anna <[email protected]>
Co-authored-by: Jennifer Weir <[email protected]>
Co-authored-by: Jennifer Weir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brunoocasali