Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.10.0] AI-powered search changes #576

Open
6 tasks
brunoocasali opened this issue Aug 27, 2024 · 0 comments
Open
6 tasks

[v1.10.0] AI-powered search changes #576

brunoocasali opened this issue Aug 27, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

Following this central issue

Explanation of the feature

  • Rest embedder
    • Removed parameters: query, inputField, inputType, pathToEmbeddings and embeddingObject.
    • Replaced by request and response
    • New parameter: headers
  • Add url parameter to the OpenAI embedder
  • dimensions is now available as an optional parameter for ollama embedders.

Usage: https://meilisearch.notion.site/v1-10-AI-search-changes-737c9d7d010d4dd685582bf5dab579e2?pvs=74

TODO

  • Rest embedder
    • Remove the following parameters: query, inputField, inputType, pathToEmbeddings and embeddingObject.
    • Add the new parameters request, response and headers (cf usage for more information)
  • Add url parameter to the OpenAI embedder
  • Add dimensions for Ollama embedders.
  • Update the tests accordingly
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2024
@polyfloyd polyfloyd mentioned this issue Sep 2, 2024
Merged
3 tasks
meili-bors bot added a commit that referenced this issue Sep 15, 2024
@meili-bors @polyfloyd
Merge #568
e09d86e 
568: Add Embedder.URL r=brunoocasali a=polyfloyd

# Pull Request

## What does this PR do?
Partial fix for #576

The documentation for the Ollama Embedder states that there is an `url` field that can be used to specify how Ollama can be reached. However, this field is not present yet in this client library.

See: https://www.meilisearch.com/docs/learn/experimental/vector_search#generate-auto-embeddings

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: polyfloyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brunoocasali