Skip to content

Commit

Permalink
Merge #176
Browse files Browse the repository at this point in the history
176: Remove unused generic T in search method r=brunoocasali a=ShakyaCsun

# Pull Request

## What does this PR do?
Fixes #111 
<!-- Please link the issue you're trying to fix with this PR, if none then please create an issue first. -->

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Note: This will cause breakage for users who had strict linting and assigned random type parameter for search<T>().

Co-authored-by: Srishan Shakya <[email protected]>
  • Loading branch information
bors[bot] and ShakyaCsun authored Jun 21, 2022
2 parents 0911903 + bac6deb commit 978bd9f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/src/index.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ abstract class MeiliSearchIndex {
Future<TaskInfo> delete();

/// Search for documents matching a specific query in the index.
Future<SearchResult> search<T>(
Future<SearchResult> search(
String? query, {
int? offset,
int? limit,
Expand Down
2 changes: 1 addition & 1 deletion lib/src/index_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class MeiliSearchIndexImpl implements MeiliSearchIndex {
//

@override
Future<SearchResult> search<T>(
Future<SearchResult> search(
String? query, {
int? offset,
int? limit,
Expand Down

0 comments on commit 978bd9f

Please sign in to comment.