Use a forked version of LMDB to fix a memory usage issue #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
hotfix-free-mdb-pages
branch
from
474a674
to
90a71b6
Compare
curquiza
approved these changes
Jun 21, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forked LMDB repository introduces a new
MDB_ALWAYSFREEPAGESflag that forces LMDB to call free on single pages instead of storing them in a list for future reuse.The fact that LMDB was keeping the pages in memory was, pretty obviously, impacting the memory usage of the library when big transactions were created. Even after being committed, the memory usage was high. The only way to free the memory was to drop the environment.
We are not the sole ones that were impacted by this behavior.