Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md template file #34

Merged
merged 26 commits into from
Jun 29, 2020
Merged

Add CONTRIBUTING.md template file #34

merged 26 commits into from
Jun 29, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jun 25, 2020

See #33.

Sorry for my basic english mistakes, I'm in the train and I don't have a stable connection so grammarly is not here to save me 😢

templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
erlend-sh
erlend-sh previously approved these changes Jun 25, 2020
Copy link

@erlend-sh erlend-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like your simplifications!

templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
@curquiza curquiza requested a review from eskombro June 29, 2020 11:57
@curquiza curquiza requested a review from bidoubiwa June 29, 2020 11:57
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style check before launch 🚀

templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
curquiza and others added 5 commits June 29, 2020 14:12
About this automation:
- As the draft release description is generated on every push on `master`, don't change it manually until the final release publishment.
- If you don't want a PR to appear in the release changelogs: add the label `skip-changelog`. We suggest removing PRs updating the README or the CI (except for big changes).
- If the changes you are doing in the PR are breaking: add the label `breaking-change`. In the release tag, the minor will be increased instead of the patch. The major will never be changed until [MeiliSearch](https://github.com/meilisearch/MeiliSearch) is stable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If the changes you are doing in the PR are breaking: add the label `breaking-change`. In the release tag, the minor will be increased instead of the patch. The major will never be changed until [MeiliSearch](https://github.com/meilisearch/MeiliSearch) is stable.
- If the changes you are doing in the PR are breaking: add the label `breaking-change`. In the release version, the minor will be increased instead of the patch. The major will never be changed until [MeiliSearch](https://github.com/meilisearch/MeiliSearch) is stable.

templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
@curquiza curquiza merged commit c4a827c into master Jun 29, 2020
@curquiza curquiza deleted the contributing branch June 29, 2020 13:10
@curquiza curquiza mentioned this pull request Jul 2, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants