Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.30: swap indexes #1992

Merged
merged 12 commits into from
Nov 23, 2022
Merged

v0.30: swap indexes #1992

merged 12 commits into from
Nov 23, 2022

Conversation

maryamsulemani97
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 commented Nov 1, 2022 •
edited
Loading

closes #1960

Some links may not work until this is merged with #1976

For reviewers

I didn't write a separate guide for index swapping as there isn't enough content for a separate page. I did include everything from this comment and added it to core concepts

@maryamsulemani97 maryamsulemani97 added this to the v0.30 milestone Nov 1, 2022
@maryamsulemani97 maryamsulemani97 mentioned this pull request Nov 1, 2022
Merged
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review November 10, 2022 11:14
gmourier
gmourier requested changes Nov 14, 2022
View reviewed changes
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
Kerollmops
Kerollmops requested changes Nov 14, 2022
View reviewed changes
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
reference/errors/error_codes.md Outdated Show resolved Hide resolved
reference/api/indexes.md Outdated Show resolved Hide resolved
guimachiavelli
guimachiavelli requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine for release, but I'm thinking we might need a guide on index swapping. As it is, we're basically giving users a reference, a quick description, and hoping they'll know what to do.

learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
reference/api/indexes.md Outdated Show resolved Hide resolved
@maryamsulemani97
Copy link
Contributor Author

but I'm thinking we might need a guide on index swapping.

@guimachiavelli
I don't think we have enough content for a separate page. I did include everything from this #1992 (comment) and added it to core concepts

@dichotommy dichotommy self-assigned this Nov 21, 2022
@maryamsulemani97 maryamsulemani97 mentioned this pull request Nov 23, 2022
Closed
dichotommy
dichotommy suggested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks pretty good to me. I think the primary source of uncertainty for me as a reader is whether swapping two indexes will also swap their documents (I would expect it to).

.code-samples.meilisearch.yaml Show resolved Hide resolved
reference/api/indexes.md Outdated Show resolved Hide resolved
reference/api/indexes.md Outdated Show resolved Hide resolved
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
reference/api/indexes.md Outdated Show resolved Hide resolved
reference/api/indexes.md Outdated Show resolved Hide resolved
reference/errors/error_codes.md Outdated Show resolved Hide resolved
@maryamsulemani97 maryamsulemani97 removed their assignment Nov 21, 2022
@dichotommy dichotommy self-assigned this Nov 22, 2022
dichotommy
dichotommy approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🏄🏻 😎

@maryamsulemani97
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 23, 2022

Build succeeded:

@bors bors bot merged commit 9f3b31f into delete-and-cancel-tasks Nov 23, 2022
@bors bors bot deleted the v0.30--swap-indexes branch November 23, 2022 07:14
bors bot added a commit that referenced this pull request Nov 24, 2022
@bors @maryamsulemani97
Merge #1976
34685e8 
1976: v0.30: Delete and cancel tasks r=maryamsulemani97 a=maryamsulemani97

closes #1998 

This is also a staging PR for #1981, #1983, #1985, and #1992 . Since these PRs will affect the same pages, I made some changes here


Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops requested changes

@dichotommy dichotommy dichotommy approved these changes

@guimachiavelli guimachiavelli Awaiting requested review from guimachiavelli

@gmourier gmourier Awaiting requested review from gmourier

Assignees

@dichotommy dichotommy

Labels
None yet
Projects
None yet
Milestone
v0.30
Development

Successfully merging this pull request may close these issues.
5 participants
@maryamsulemani97 @guimachiavelli @Kerollmops @gmourier @dichotommy