v0.28: Smart cropping #1730
Merged
v0.28: Smart cropping #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since @ManyTheFish is in vacations for 2 weeks, I recommend putting @gmourier as a review in the meantime 😇 |
gmourier
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
LGTM @guimachiavelli ! IMO This is well explained 🥷 🐢 . Congrats 🏆
curquiza
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
For me it's ok, but be careful, I don't have at all the @ManyTheFish and @gmourier knowledge on it
dichotommy
reviewed
Jun 23, 2022
Co-authored-by: Tommy <[email protected]>
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1687