Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.30: update settings page for null values #1961

Closed
maryamsulemani97 opened this issue Oct 25, 2022 · 4 comments · Fixed by #1972
Closed

v.30: update settings page for null values #1961

maryamsulemani97 opened this issue Oct 25, 2022 · 4 comments · Fixed by #1972
Assignees
@maryamsulemani97
Milestone
v0.30

Comments

@maryamsulemani97
Copy link
Contributor

Some settings should throw an error when given null

  • Update the "Update settings" section of the Settings API
  • Update specific settings' "update" section

References
@maryamsulemani97 maryamsulemani97 added this to the v0.30 milestone Oct 25, 2022
@maryamsulemani97 maryamsulemani97 self-assigned this Oct 25, 2022
@maryamsulemani97 maryamsulemani97 mentioned this issue Oct 26, 2022
Merged
@guimachiavelli guimachiavelli linked a pull request Nov 2, 2022 that will close this issue
v0.30 #1972
Merged
@maryamsulemani97 maryamsulemani97 mentioned this issue Nov 3, 2022
Closed
@guimachiavelli
Copy link
Member

FYI, just noticed there's some discussion on this which I think might significantly change what we need to update:

meilisearch/meilisearch#2929 (comment)

No actual decision yet, just something to keep an eye on before merging, I guess.

@curquiza
Copy link
Member

curquiza commented Nov 8, 2022

I confirm, let's wait for the Guillaume's final word on it, sorry for the confusion docs team!

@curquiza
Copy link
Member

curquiza commented Nov 9, 2022

Confirmation, nothing to change on the code part -> meilisearch/meilisearch#2929 (comment)

@maryamsulemani97
Copy link
Contributor Author

Closing since we have nothing to update on the docs

bors bot added a commit that referenced this issue Nov 28, 2022
@bors @maryamsulemani97
Merge #1972
b853765 
1972: v0.30 r=maryamsulemani97 a=maryamsulemani97

Staging branch for v0.30

For all v0.30 PRs, create child branches off this 

closes #1971, #1970, #1969, #1966, #1965, #1964, #1963, #1962, #1961, #1960, #1959, #1958, #1957, #1956, #2006, #2003, #2001, #1999, #1998, 

Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryamsulemani97 maryamsulemani97

Labels
None yet
Projects
None yet
Milestone
v0.30
Development

Successfully merging a pull request may close this issue.

v0.30 meilisearch/documentation
3 participants
@guimachiavelli @curquiza @maryamsulemani97