Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.29: Updates to auto-batching #1838

Closed
6 tasks done
maryamsulemani97 opened this issue Aug 24, 2022 · 7 comments · Fixed by #1864
Closed
6 tasks done

v0.29: Updates to auto-batching #1838

maryamsulemani97 opened this issue Aug 24, 2022 · 7 comments · Fixed by #1864
Milestone

Comments

@maryamsulemani97
Copy link
Contributor

maryamsulemani97 commented Aug 24, 2022

With v0.29, auto-batching is enabled by default.

  • Remove the Experimental section from the docs
  • Move Auto-batching somewhere else. Maybe Advanced topics. Does it even need its own page now?
  • Update the page to remove the current options: --debounce-duration-sec, --max-batch-size, and --max-documents-per-batch
  • Remove batchUid from the task object as it is now an internal field
  • Add new instance option: --disable-auto-batching and environment variable: MEILI_DISABLE_AUTO_BATCHING
  • Mention auto-batching in quick start

References:

@curquiza
Copy link
Member

curquiza commented Aug 24, 2022

Pinging @Kerollmops who can be a better SME than me on it 😇

@curquiza
Copy link
Member

Also, we can remove the recommendation about indexing by batch here: https://docs.meilisearch.com/learn/advanced/indexing.html#improving-indexing-performance

@guimachiavelli
Copy link
Member

Two things that might be relevant when working on this issue:

  1. Change the behavior of auto-batching error catching meilisearch#2478 might be worth a quick read
  2. Not sure if we should mention it (probably more of a changelog thing), but FYI launching meilisearch v0.29 with the current options will throw an error

@curquiza
Copy link
Member

curquiza commented Aug 31, 2022

Not sure if we should mention it (probably more of a changelog thing), but FYI launching meilisearch v0.29 with the current options will throw an error

Since this feature was in beta this is something not mandatory to write. My opinion is we handle this on the changelog side and on the associated discussion side, but not necessarily on the docs side. However, I don't have a strong opinion, and both are correct to me. So, it's up to you of course 😇

@guimachiavelli
Copy link
Member

Yeap, agreed. I'll leave the final decision to @maryamsulemani97, just wanted her to be aware of it since we did briefly discuss it during the opensource meeting.

@maryamsulemani97
Copy link
Contributor Author

@Kerollmops
Can you please describe a situation where disabling auto-batching might be useful? We would like to add a sentence or two on what users can gain from disabling this feature.

@Kerollmops
Copy link
Member

@maryamsulemani97, one of the reasons I currently see where it would be helpful to disable the auto-batching system would be to:

  1. Avoid a potential bug in the auto-batching system itself.
  2. Reduce the visibility latency. If the engine indexes documents in big chunks it will take more time to be able to see the documents of the first task in a search query. If you disable the auto-batching, the whole queue will take much more time to be processed, but each individual task will be available earlier (until a certain amount of processed tasks).

bors bot added a commit that referenced this issue Oct 3, 2022
1859: v0.29 r=maryamsulemani97 a=guimachiavelli

This is a staging PR for all changes related to Meilisearch v0.29.

Please avoid making changes directly to this PR; instead, create new child branches based off this one.

Closes meilisearch/integration-guides#213, #1854, #1853, #1852, #1851, #1840, #1839, #1838, #1837, #1846


Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Maryam <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>
@bors bors bot closed this as completed in 4a20895 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants