Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: X-Meilisearch-Client #1691

Closed
guimachiavelli opened this issue Jun 7, 2022 · 3 comments
Closed

v0.28: X-Meilisearch-Client #1691

guimachiavelli opened this issue Jun 7, 2022 · 3 comments
Assignees
@maryamsulemani97
Milestone
v0.28

Comments

@guimachiavelli
Copy link
Member

guimachiavelli commented Jun 7, 2022 •
edited by dichotommy
Loading

v0.28 adds a new HTTP header, X-Meilisearch-Client. Its main goal seems to be helping us properly collect user agent data identifying which SDK or official tool is accessing an instance.

At a first look, this does not seem to impact the docs. Whoever's assigned the issue should confirm this with the SME.

References

Issue on core: meilisearch/meilisearch#2367
Spec: https://github.com/meilisearch/specifications/pull/150/files
SME: @gmourier
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 7, 2022
@gmourier
Copy link
Member

gmourier commented Jun 7, 2022

Hi @guimachiavelli! I can't edit the title, the right header is X-Meilisearch-Client 😇

@guimachiavelli guimachiavelli changed the title v0.28: X-Meilisearch-Header v0.28: X-Meilisearch-Client Jun 9, 2022
@guimachiavelli
Copy link
Member Author

guimachiavelli commented Jun 9, 2022 •
edited
Loading

oops! That's what I get when I try to cram reading everything v0.28-related in one day. Thanks, fixed!

@guimachiavelli guimachiavelli mentioned this issue Jun 15, 2022
Merged
@maryamsulemani97
Copy link
Contributor

Confirmed with @gmourier, this doesn't impact the docs

bors bot added a commit that referenced this issue Jul 11, 2022
@bors @guimachiavelli
@dichotommy @maryamsulemani97
Merge #1707
00cb6df 
1707: v0.28 r=guimachiavelli a=guimachiavelli

This is a staging PR for all changes related to Meilisearch v0.28.

Please avoid making changes directly to this PR; instead, create new child branches based off this one.

Closes #1687, #1688, #1691, #1692, #1693, #1694, #1699, #1700, #1701, #1702, #1703, #1704, #1706, #1722, #1727, #561

Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Tommy Melvin <[email protected]>
Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryamsulemani97 maryamsulemani97

Labels
None yet
Projects
None yet
Milestone
v0.28
Development

No branches or pull requests
3 participants
@guimachiavelli @gmourier @maryamsulemani97