No findOne(id) #2524
Merged
No findOne(id) #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmn
added a commit
to mgmn/misskey-v11
that referenced
this pull request
Apr 6, 2024
This reverts commit 01fe3bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: #2523
Validationされてるから問題ないはずだけど、ねんのため
findOne(id)は使わないようにする。そのうちTypeORM 0.30.0 以降にする。
メモ
だいたいパターン置換でいい
Polls, UserProfiles, UserKeypair, UserPublickeys のプライマリキー名はidではない
findOne(query)とかは置換しないように