-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-pass listen to zarr, reconstruct, and fill napari layers #451
Conversation
which has been unmaintained
* load "Phase3D" reconstruction in target reconstruction * displey (10 MB) in sample contribution menu * add zebrafish embryo contribution (local) * First draft README * example data movies * < 100 MB * update links to v1.5 * Update README.md Co-authored-by: Ziwen Liu <[email protected]> * slightly changed wording * add installation movie * delete old data * fix tests --------- Co-authored-by: Ziwen Liu <[email protected]>
* direct link * use raw link --------- Co-authored-by: Ziwen Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## v1-gui-layout #451 +/- ##
================================================
- Coverage 8.86% 8.09% -0.77%
================================================
Files 29 31 +2
Lines 4547 4866 +319
================================================
- Hits 403 394 -9
- Misses 4144 4472 +328
|
@talonchandler , @ziw-liu I think it is fine to use vanilla zarr or dask if it makes lazy loading of zarr easier than with iohub.
I am not sure if this is the best, but |
@ziw-liu and I chatted and agreed that we should assume a finite (and known) number of time points. This lets us use the existing CLI. I've updated this branch with a first-pass implementation. |
This is a rudimentary, single-threaded attempt at our "listen-to-zarr" strategy.
@ziw-liu I ran into at least three challenges this afternoon/evening:
create_empty_zarr
, but now I don't know the number of time points in advance, so I needed to create it for the first time point then append for subsequent time points.tmp.zarr
then copy it into the final .zarr. We may need to rework the API...but I think this suboptimal strategy can work for now.Many of my difficulties stemmed from the unknown number of time points. Clinton assumed that he knew the number of times, right? Would relaxing this constraint make sense for tomorrow?