Skip to content
This repository has been archived by the owner on Jul 29, 2023. It is now read-only.

Inference bug, pandas docker version #153

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Inference bug, pandas docker version #153

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db8ee0e
fix channel_name bug
JohannaRahm Jun 3, 2022
2d2cb8c
set pandas to 0.24.2 in docker requirements
JohannaRahm Jun 3, 2022
e09adea
add test & update docstring for aux_utils - get_sms_im_name function
JohannaRahm Jun 16, 2022
c1cbb1d
refactor aux utils test
JohannaRahm Jun 16, 2022
1326aaf
change channel_name if statement to cover NaN
JohannaRahm Jun 16, 2022
79d714c
split tests in two functions
JohannaRahm Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micro_dl/utils/aux_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def get_sms_im_name(time_idx=None,
"""

im_name = "img"
if np.isnan(channel_name):
if channel_name is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this bug. The channel_name can actually be a NaN when loading a frames metadata csv file with pandas, so would it work to replace the line with:
if not pd.isnull(channel_name): ?
The reason this bug escaped notice is because there are no tests for get_sms_im_name in aux_utils_tests.py, so bonus points if you add a test. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I replaced the line with if not pd.isnull(channel_name): and added a test. Curious about your feedback! :)

im_name += "_" + str(channel_name)
if time_idx is not None:
im_name += "_t" + str(time_idx).zfill(int2str_len)
Expand Down
2 changes: 1 addition & 1 deletion requirements_docker.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ natsort==6.0.0
nose==1.3.7
numpy==1.21.0
opencv-python==4.4.0.40
pandas==1.1.5
pandas==0.24.2
jennyfolkesson marked this conversation as resolved.
Show resolved Hide resolved
protobuf==3.20.1
pydot==1.4.1
PyYAML>=5.4
Expand Down