Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump torch to 2.4.1 #174

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Bump torch to 2.4.1 #174

merged 3 commits into from
Sep 28, 2024

Conversation

edyoshikun
Copy link
Contributor

need to update torch>2.4.1 for #151 to be effective.

Otherwise you get the error:

@torch.amp.custom_fwd(device_type="cuda", cast_inputs=torch.float32)
AttributeError: module 'torch.amp' has no attribute 'custom_fwd'

@edyoshikun edyoshikun requested a review from ziw-liu September 26, 2024 01:16
ziw-liu
ziw-liu approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ziw-liu
Copy link
Collaborator

ziw-liu commented Sep 26, 2024

Base branch needs formatting.

@ziw-liu ziw-liu added maintenance Maintenance work translation Image translation (VS) labels Sep 26, 2024
@ziw-liu ziw-liu changed the title Bug in torch.amp.custom_fwd Bump torch to 2.4.1 Sep 26, 2024
@edyoshikun edyoshikun merged commit 4c1b094 into ram_dataloader Sep 28, 2024
4 checks passed
@edyoshikun edyoshikun deleted the torch241 branch September 28, 2024 01:18
ziw-liu pushed a commit that referenced this pull request Oct 21, 2024
@edyoshikun @ziw-liu
Bump torch to 2.4.1 (#174)
85ea791 
* update torch >2.4.1

* black

* ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziw-liu ziw-liu ziw-liu approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance work translation Image translation (VS)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edyoshikun @ziw-liu