updating the notebook after running it at DLMBL2024 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Diane Adjavon <[email protected]> Co-authored-by: AlbertDominguez <[email protected]> Co-authored-by: Anna Foix <[email protected]>
edyoshikun
force-pushed
the
update_dlmbl2024
branch
from
0c68ab7 to
784dae7
Compare
|
@edyoshikun Let's add the |
installation
|
the last commit addresses #152 |
mattersoflight
previously requested changes
Aug 31, 2024
There was a problem hiding this comment.
@edyoshikun thanks for iterating on the organization of examples folder. It needs some more cleaning. I suggest:
- Release 0.2.0
- Merge this branch into the main after organizing files.
- Start a small PR that shows a demo of inference for Zernike phase contrast.
- Release 0.2.1.
- adding the phase contrast example - saving the PhC notebook with images
ziw-liu
reviewed
Sep 4, 2024
ziw-liu
reviewed
Sep 4, 2024
ziw-liu
reviewed
Sep 4, 2024
ziw-liu
reviewed
Sep 4, 2024
ziw-liu
reviewed
Sep 5, 2024
ziw-liu
reviewed
Sep 5, 2024
ziw-liu
reviewed
Sep 5, 2024
ziw-liu
reviewed
Sep 5, 2024
ziw-liu
reviewed
Sep 6, 2024
- description on docstrings for inference demo scripts
ziw-liu
approved these changes
Sep 6, 2024
edyoshikun
dismissed
mattersoflight’s stale review
the points have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR udpates the DLMBL2024 notebook for demo-ing Virtual Staining with VisCy.
After many inputs and debugging from Diane, Anna, and Albert.
Co-authored-by: Diane Adjavon [email protected]
Co-authored-by: AlbertDominguez [email protected]
Co-authored-by: Anna Foix [email protected]