Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metric EaseProbe_ping_loss Add by mistake #533

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

fangpsh
Copy link
Contributor

@fangpsh fangpsh commented Jun 4, 2024

  • gauge metric should be SET value, not ADD.
  • fix MaxRtt metric loss.

@fangpsh
Copy link
Contributor Author

fangpsh commented Jun 4, 2024

I have found the commit that caused this bug, maybe we should re-review this pull request:

https://github.com/megaease/easeprobe/pull/386/files#diff-2905b6c764234f33b4bf658a5c5e0fa0d82289c07f56455c6ed348e60c296c36L142

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (eef3a25) to head (5460418).
Report is 34 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   98.80%   98.71%   -0.09%     
==========================================
  Files          85       85              
  Lines        5867     5858       -9     
==========================================
- Hits         5797     5783      -14     
- Misses         51       56       +5     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samanhappy
Copy link
Collaborator

Thanks for your contribution. These are indeed mistakes that were introduced in the previous PR.

@suchen-sci suchen-sci merged commit cbe6124 into megaease:main Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants