Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #523
In
channel.go
within theChannel.WatchEvent
function, the code checksresult
and uses its information to decide whether to send a notification. However, innotification_strategy.go
, theNotificationStrategyData.ProcessStatus
function updates the status and the number of notifications sent.This means that in the case of #523, since the failure count is set to 2 and a failure occurs in the
init
state, the channel does not send a notification because it is in theinit
state. However,NotificationStrategyData
considers the notification already sent andIsExceedMaxTimes
returns true.As a result, no notification is sent. To fix this problem, when in the init state,
NotificationStrategyData
should not be updated. According to the logic and comments inchannel.go
,init
is a special state. This fix should be fine.