Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid random websocket test failures by waiting for http server to start #474

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

samanhappy
Copy link
Collaborator

@samanhappy samanhappy commented Jan 12, 2024

There were some random test failures for TestWSPing, as shown here.

These failures should emerged when the test cases began running before the http server was ready.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (707e216) 99.08% compared to head (06a0397) 98.78%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   99.08%   98.78%   -0.31%     
==========================================
  Files          82       85       +3     
  Lines        5820     5863      +43     
==========================================
+ Hits         5767     5792      +25     
- Misses         40       52      +12     
- Partials       13       19       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suchen-sci suchen-sci merged commit b20cabd into megaease:main Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants